From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9EE5E61FCE; Fri, 27 Sep 2024 12:04:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727438644; cv=none; b=X3jMH4ZqvsOamO152WLwN7p7AAmlAcyPj0eFeE48MsVi5XHTbJ0KwAAr9HUsLms3R/o7TtcoF7Nm43NpyJ0jtORDahfK5LqrHHWA1gqA7x9+Df9TCCn9Jx5CXAZTIW9eHYyTc3LtBw5z4BbMRqOa8pYuhB8XNL8slYWSILQl0To= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727438644; c=relaxed/simple; bh=tVqjFHEaB7hFNxzh+RNievSG+KxIiC6UbwlmwhcDrRM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=sr/JWlGvLRJhqEM4Kmq1D6d7HnYZJ/9Cr1KPT9jjBcXxkc1TuSnzeWgzOpSZtWcGjY2n+jvyFmpIMqXh4nMd7AWphnl4izMM9mMvHydQQ0xjff4/Tn1AGLZogr1s4PU2ILtvCVzutoJcuLOord57OqSMzOOQhYDQJbr/8UIwh8c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=DenDDL2G; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="DenDDL2G" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 81C54C4CEC4; Fri, 27 Sep 2024 12:03:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1727438644; bh=tVqjFHEaB7hFNxzh+RNievSG+KxIiC6UbwlmwhcDrRM=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=DenDDL2GxaPEhzEqEClzghH5qrkQLS8s7dK4p7RnucnqYhu5DRl3scTLgZJAbn5kD pH8iMFhLvLWvEGON1tW2qDlTinPyxswCBjtxymTQa2LuTi2oFV7+3nXCuR4PdSziAq k4oUg/iC9h2JpXbxSxsydqLbnH1GqNv8m/10l7piZNxVDJaTCh0HmQf6BmbnFEqt0Z gjKlr2Xmngn+VssbFI5EjHfdX0nNlIknn4AAk0nImakhmFXzNUktBOl0CvYgxCHuFf Ho1keslgRwYL6GQNCdsncnRu/WHim4C7hc48E+NukmdtjlTHZazp6xkAuBpCZh6G8W QMXsYlBqdN/QQ== Message-ID: <52f83419-cc5e-49f3-90a7-26a5b4ddd5a0@kernel.org> Date: Fri, 27 Sep 2024 14:03:57 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/4] dt-bindindgs: i2c: qcom,i2c-geni: Document shared flag To: Konrad Dybcio , Mukesh Kumar Savaliya Cc: konrad.dybcio@linaro.org, andersson@kernel.org, andi.shyti@kernel.org, linux-arm-msm@vger.kernel.org, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org, conor+dt@kernel.org, agross@kernel.org, devicetree@vger.kernel.org, vkoul@kernel.org, linux@treblig.org, dan.carpenter@linaro.org, Frank.Li@nxp.com, bryan.odonoghue@linaro.org, krzk+dt@kernel.org, robh@kernel.org References: <20240927063108.2773304-1-quic_msavaliy@quicinc.com> <20240927063108.2773304-2-quic_msavaliy@quicinc.com> <320e0685-3dae-42a7-a387-75f6f52f4090@kernel.org> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJgPO8PBQkUX63hAAoJEBuTQ307 QWKbBn8P+QFxwl7pDsAKR1InemMAmuykCHl+XgC0LDqrsWhAH5TYeTVXGSyDsuZjHvj+FRP+ gZaEIYSw2Yf0e91U9HXo3RYhEwSmxUQ4Fjhc9qAwGKVPQf6YuQ5yy6pzI8brcKmHHOGrB3tP /MODPt81M1zpograAC2WTDzkICfHKj8LpXp45PylD99J9q0Y+gb04CG5/wXs+1hJy/dz0tYy iua4nCuSRbxnSHKBS5vvjosWWjWQXsRKd+zzXp6kfRHHpzJkhRwF6ArXi4XnQ+REnoTfM5Fk VmVmSQ3yFKKePEzoIriT1b2sXO0g5QXOAvFqB65LZjXG9jGJoVG6ZJrUV1MVK8vamKoVbUEe 0NlLl/tX96HLowHHoKhxEsbFzGzKiFLh7hyboTpy2whdonkDxpnv/H8wE9M3VW/fPgnL2nPe xaBLqyHxy9hA9JrZvxg3IQ61x7rtBWBUQPmEaK0azW+l3ysiNpBhISkZrsW3ZUdknWu87nh6 eTB7mR7xBcVxnomxWwJI4B0wuMwCPdgbV6YDUKCuSgRMUEiVry10xd9KLypR9Vfyn1AhROrq AubRPVeJBf9zR5UW1trJNfwVt3XmbHX50HCcHdEdCKiT9O+FiEcahIaWh9lihvO0ci0TtVGZ MCEtaCE80Q3Ma9RdHYB3uVF930jwquplFLNF+IBCn5JRzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmA872oFCRRflLYACgkQG5NDfTtBYpvScw/9GrqBrVLuJoJ52qBBKUBDo4E+5fU1bjt0 Gv0nh/hNJuecuRY6aemU6HOPNc2t8QHMSvwbSF+Vp9ZkOvrM36yUOufctoqON+wXrliEY0J4 ksR89ZILRRAold9Mh0YDqEJc1HmuxYLJ7lnbLYH1oui8bLbMBM8S2Uo9RKqV2GROLi44enVt vdrDvo+CxKj2K+d4cleCNiz5qbTxPUW/cgkwG0lJc4I4sso7l4XMDKn95c7JtNsuzqKvhEVS oic5by3fbUnuI0cemeizF4QdtX2uQxrP7RwHFBd+YUia7zCcz0//rv6FZmAxWZGy5arNl6Vm lQqNo7/Poh8WWfRS+xegBxc6hBXahpyUKphAKYkah+m+I0QToCfnGKnPqyYIMDEHCS/RfqA5 t8F+O56+oyLBAeWX7XcmyM6TGeVfb+OZVMJnZzK0s2VYAuI0Rl87FBFYgULdgqKV7R7WHzwD uZwJCLykjad45hsWcOGk3OcaAGQS6NDlfhM6O9aYNwGL6tGt/6BkRikNOs7VDEa4/HlbaSJo 7FgndGw1kWmkeL6oQh7wBvYll2buKod4qYntmNKEicoHGU+x91Gcan8mCoqhJkbqrL7+nXG2 5Q/GS5M9RFWS+nYyJh+c3OcfKqVcZQNANItt7+ULzdNJuhvTRRdC3g9hmCEuNSr+CLMdnRBY fv0= In-Reply-To: <320e0685-3dae-42a7-a387-75f6f52f4090@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 27/09/2024 13:20, Konrad Dybcio wrote: > On 27.09.2024 11:24 AM, Krzysztof Kozlowski wrote: >> On Fri, Sep 27, 2024 at 12:01:05PM +0530, Mukesh Kumar Savaliya wrote: >>> Adds qcom,shared-se flag usage. Use this when particular I2C serial >>> controller needs to be shared between two subsystems. >>> >>> SE = Serial Engine, meant for I2C controller here. >>> TRE = Transfer Ring Element, refers to Queued Descriptor. >>> SS = Subsystems (APPS processor, Modem, TZ, ADSP etc). >>> >>> Example : >>> Two clients from different SS can share an I2C SE for same slave device >>> OR their owned slave devices. >>> Assume I2C Slave EEPROM device connected with I2C controller. >>> Each client from ADSP SS and APPS Linux SS can perform i2c transactions. >>> This gets serialized by lock TRE + DMA Transfers + Unlock TRE at HW level. >>> >>> Signed-off-by: Mukesh Kumar Savaliya >>> --- >>> Documentation/devicetree/bindings/i2c/qcom,i2c-geni-qcom.yaml | 4 ++++ >>> 1 file changed, 4 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/i2c/qcom,i2c-geni-qcom.yaml b/Documentation/devicetree/bindings/i2c/qcom,i2c-geni-qcom.yaml >>> index 9f66a3bb1f80..3b9b20a0edff 100644 >>> --- a/Documentation/devicetree/bindings/i2c/qcom,i2c-geni-qcom.yaml >>> +++ b/Documentation/devicetree/bindings/i2c/qcom,i2c-geni-qcom.yaml >>> @@ -60,6 +60,10 @@ properties: >>> power-domains: >>> maxItems: 1 >>> >>> + qcom,shared-se: >>> + description: True if I2C needs to be shared between two or more subsystems(SS). >> >> The "SS" and subsystem should be explained in the binding. Please do not >> use some qcom-specific abbreviations here, but explain exactly, e.g. >> processors like application processor and DSP. >> >> "se" is also not explained in the binding - please open it and look for >> such explanation. >> >> This all should be rephrased to make it clear... We talked about this >> and I do not see much of improvements except commit msg, so we are >> making circles. I don't know, get someone internally to help you in >> upstreaming this. >> >> Is sharing of IP blocks going to be also for other devices? If yes, then >> this should be one property for all Qualcomm devices. If not, then be >> sure that this is the case because I will bring it up if you come with >> one more solution for something else. > > As far as I understand, everything that's not protocol-specific (in > this case it would be I2C tunables etc.) is common across all > protocols supported by the serial engine. Yeah, but I also think about other things like clock controllers, TLMMs, MMUs and so on. Each of them will get a new "qcom,shared-xxx" property? I expect Mukesh to solve it in qcom-wide way, not only his one problem. Best regards, Krzysztof