From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C1BCC32772 for ; Tue, 23 Aug 2022 16:22:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242127AbiHWQW4 (ORCPT ); Tue, 23 Aug 2022 12:22:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40976 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244479AbiHWQWi (ORCPT ); Tue, 23 Aug 2022 12:22:38 -0400 Received: from mail-lj1-x231.google.com (mail-lj1-x231.google.com [IPv6:2a00:1450:4864:20::231]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A4D3C14F6F1 for ; Tue, 23 Aug 2022 05:46:35 -0700 (PDT) Received: by mail-lj1-x231.google.com with SMTP id z20so13410037ljq.3 for ; Tue, 23 Aug 2022 05:46:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc; bh=7vkbXTvEIxbamOzsPAlGZ18SKerzAATRGx48coFp9Wg=; b=l5rKdPLdrKNmWz0BuIx5srFeLQYtPJCncEBzmf732FKCQHG1Tc2h5SoAWxHbFwRWqw V6gAvZKEe6vcz0E2JCvMSKBfJWQ56xD/lib/nApBuoYRpYtQqIHYrD2HHFbewsIKhgX2 ezOgZLmABxQd2gdesxFpeXIxq37TxapUObiaB4/R9AB0gtJ/iNoqSkof+JI84ihhiR6A A+Cj3Y194a+cs9HBaY1VoGvLA0ls4wvHQFz+oECN3JZ8yx/fcsS8zi2Sv/FcsP8C1XSd d/Hrgv16iUHPBapIlIJbjEvueUfb3BVYG1lQzNwHNNe11okQDh2ellT1XY73dHmlzr7h g05g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=7vkbXTvEIxbamOzsPAlGZ18SKerzAATRGx48coFp9Wg=; b=KPVM7a4ZpBE7K/H2td3jLM3nvESjVmBq36T4pt6z26Mp75NGI8kDXjfu2ugfVz1S3+ XbkpBolP261eqTIpu6RDZ3rUjKkGAe/kz5Kc6mJCsT9+YwHYcT83jVi9yTj4S6hvL6s0 7qcKoXBUKdPQAh0KZ2Q7UvnLfXbsnbkR5yQ49qtX03LUO02papypuEZGhv4et30J53ao dJvJM/Hrrfp7AC6vC70lY4sDtdcKLgt9YGN4wWiHTMyj1mEwBOEJysHYVeUyp4hbpQkR 8HOLacKY1ZO8Npb6K4LJ0xGigHYRSwRfrrnDsgQsaD92AJe5x6ocl9jBYSIJm6UB8dn9 kGTA== X-Gm-Message-State: ACgBeo3QY+qyCqe66qCm7vZdQaN9jcnH7lCiIf700d8CN+6pA4atIzxD DhBYf3bEc41zdjRzoBvvYqcY7g== X-Google-Smtp-Source: AA6agR5SszPK3XHuOtFzT/k6vG6kVjVdUaiPFlhBDCHwPoFxRVvMVwXQz0HMrHgJlmvjrajPesHbTw== X-Received: by 2002:a2e:a552:0:b0:25e:6fa1:a6c4 with SMTP id e18-20020a2ea552000000b0025e6fa1a6c4mr6557211ljn.90.1661258793251; Tue, 23 Aug 2022 05:46:33 -0700 (PDT) Received: from [192.168.0.11] (89-27-92-210.bb.dnainternet.fi. [89.27.92.210]) by smtp.gmail.com with ESMTPSA id h16-20020a2e5310000000b0025e5cd1620fsm2355736ljb.57.2022.08.23.05.46.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 23 Aug 2022 05:46:32 -0700 (PDT) Message-ID: <52fa28d6-4d48-bd0c-40e6-4f8855c4eac8@linaro.org> Date: Tue, 23 Aug 2022 15:46:31 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH v2 1/2] dt-bindings: edac: Add bindings for Xilinx ZynqMP OCM Content-Language: en-US To: Sai Krishna Potthuri , Rob Herring , Krzysztof Kozlowski , Michal Simek , Borislav Petkov , Mauro Carvalho Chehab , Tony Luck , James Morse , Robert Richter Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-edac@vger.kernel.org, saikrishna12468@gmail.com, git@amd.com, Shubhrajyoti Datta References: <20220822115821.3907-1-sai.krishna.potthuri@amd.com> <20220822115821.3907-2-sai.krishna.potthuri@amd.com> From: Krzysztof Kozlowski In-Reply-To: <20220822115821.3907-2-sai.krishna.potthuri@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 22/08/2022 14:58, Sai Krishna Potthuri wrote: > From: Shubhrajyoti Datta > > Add bindings for Xilinx ZynqMP OCM controller. > > Signed-off-by: Shubhrajyoti Datta > Signed-off-by: Sai Krishna Potthuri > --- > .../bindings/edac/xlnx,zynqmp-ocmc.yaml | 45 +++++++++++++++++++ > 1 file changed, 45 insertions(+) > create mode 100644 Documentation/devicetree/bindings/edac/xlnx,zynqmp-ocmc.yaml > > diff --git a/Documentation/devicetree/bindings/edac/xlnx,zynqmp-ocmc.yaml b/Documentation/devicetree/bindings/edac/xlnx,zynqmp-ocmc.yaml > new file mode 100644 > index 000000000000..6389fcb7ed69 > --- /dev/null > +++ b/Documentation/devicetree/bindings/edac/xlnx,zynqmp-ocmc.yaml > @@ -0,0 +1,45 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/edac/xlnx,zynqmp-ocmc.yaml# Filename should be based on compatible, so xlnx,zynqmp-ocmc-1.0.yaml > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Xilinx Zynqmp OCM(On-Chip Memory) Controller So this is a memory controller, then please put the bindings in the memory-controllers directory. > + > +maintainers: > + - Shubhrajyoti Datta > + - Sai Krishna Potthuri > + > +description: | > + The OCM supports 64-bit wide ECC functionality to detect multi-bit errors > + and recover from a single-bit memory fault.On a write, if all bytes are > + being written, the ECC is generated and written into the ECC RAM along with > + the write-data that is written into the data RAM. If one or more bytes are > + not written, then the read operation results in an correctable error or > + uncorrectable error. > + > +properties: > + compatible: > + const: xlnx,zynqmp-ocmc-1.0 > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > +required: > + - compatible > + - reg > + - interrupts > + > +unevaluatedProperties: false Instead this should be: additionalProperties: false > + > +examples: > + - | > + #include > + memory-controller@ff960000 { > + compatible = "xlnx,zynqmp-ocmc-1.0"; > + reg = <0xff960000 0x1000>; > + interrupts = <0 10 IRQ_TYPE_LEVEL_HIGH>; What does 0 stand for? I commented about it already. > + }; Best regards, Krzysztof