From mboxrd@z Thu Jan 1 00:00:00 1970 From: Guenter Roeck Subject: Re: [PATCH] hwmon: twl4030-madc-hwmon: Add device tree support. Date: Sun, 16 Feb 2014 08:39:54 -0800 Message-ID: <5300E9DA.501@roeck-us.net> References: <1392384058-14240-1-git-send-email-marek@goldelico.com> <20140214133101.GA17796@e106331-lin.cambridge.arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-doc-owner@vger.kernel.org To: Belisko Marek , Mark Rutland Cc: "robh+dt@kernel.org" , Pawel Moll , "ijc+devicetree@hellion.org.uk" , "galak@codeaurora.org" , "rob@landley.net" , "jdelvare@suse.de" , "grant.likely@linaro.org" , "devicetree@vger.kernel.org" , "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "lm-sensors@lm-sensors.org" , "hns@goldelico.com" List-Id: devicetree@vger.kernel.org On 02/14/2014 06:08 AM, Belisko Marek wrote: > On Fri, Feb 14, 2014 at 2:31 PM, Mark Rutland wrote: >> On Fri, Feb 14, 2014 at 01:20:58PM +0000, Marek Belisko wrote: >>> Signed-off-by: Marek Belisko >>> --- >>> Documentation/devicetree/bindings/hwmon/twl4030-madc-hwmon.txt | 9 +++++++++ >>> drivers/hwmon/twl4030-madc-hwmon.c | 10 ++++++++++ >>> 2 files changed, 19 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/hwmon/twl4030-madc-hwmon.txt >>> >>> diff --git a/Documentation/devicetree/bindings/hwmon/twl4030-madc-hwmon.txt b/Documentation/devicetree/bindings/hwmon/twl4030-madc-hwmon.txt >>> new file mode 100644 >>> index 0000000..e8016d1 >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/hwmon/twl4030-madc-hwmon.txt >>> @@ -0,0 +1,9 @@ >>> +TWL4030 MADC hwmon. >>> + >>> +Required properties: >>> +- compatible: "ti,twl4030-madc-hwmon" >>> + >>> +Example: >>> +madc-hwmon { >>> + compatible = "ti,twl4030-madc-hwmon"; >>> +}; >> >> Huh? >> >> What is this a binding for? From a look at the driver in mainline this >> just calls into functions from the twl4030 madc driver (which doesn't >> seem to have a binding). > I post bindings for twl4030-madc [1]. Without probing this driver > other things will not work (twl4030-madc-battery e.g.). > Is there better way to handle this situation? Since you are converting twl4030-madc to be an iio driver, can't you simply use the iio_hwmon bridge and declare this driver obsolete ? Guenter