From mboxrd@z Thu Jan 1 00:00:00 1970 From: Milo Kim Subject: Re: [PATCH 01/10] mfd: Add TI LMU driver Date: Wed, 19 Feb 2014 08:58:45 +0900 Message-ID: <5303F3B5.6050806@ti.com> References: <1392359450-6890-1-git-send-email-milo.kim@ti.com> <20140217095734.GD17875@lee--X1> <53030F9C.8000605@ti.com> <20140218082127.GD20218@lee--X1> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20140218082127.GD20218@lee--X1> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Lee Jones Cc: Jingoo Han , Bryan Wu , Mark Brown , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Samuel Ortiz List-Id: devicetree@vger.kernel.org Hi Lee, On 02/18/2014 05:21 PM, Lee Jones wrote: >>>> + pdata->en_gpio = of_get_named_gpio(node, "ti,enable-gpio", 0); >>> >>> There is a global DT property for this already. >> >> I've not found it yet, but I agree it looks like general property. >> So I'll replace "ti,enable-gpio" with "ti,lmu-en-gpio". > > Just re-use "gpio-enable". No need for it to be vendor specific. > Got it. Thanks! This GPIO is used for enabling the device. So, "enable-gpio" is more appropriate name, isn't it? Best regards, Milo -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html