From: Krzysztof Kozlowski <krzk@kernel.org>
To: david@ixit.cz, Neil Armstrong <neil.armstrong@linaro.org>,
Jessica Zhang <jesszhan0024@gmail.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, phone-devel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: panel: s6e3fc2x01: Sort and remove unnecessary properties
Date: Thu, 6 Nov 2025 11:46:16 +0100 [thread overview]
Message-ID: <530695ab-109a-4dd4-968b-e8624c53238d@kernel.org> (raw)
In-Reply-To: <20251106-dt-s6e3fc2x01-v1-1-0479f2d8b53f@ixit.cz>
On 06/11/2025 11:36, David Heidelberg via B4 Relay wrote:
> From: David Heidelberg <david@ixit.cz>
>
> Properties are now sorted, reset-gpio and port property dropped.
You need to explain why. Sorting is kind of obvious, but dropping
property is not.
"... because they are already accepted here as part of panel-common and
usage of unevaluatedProperties.".
Or just "because they are redundant." if you think reason for redundancy
is obvious.
>
> Fixes: 986f28f3a71e ("dt-bindings: panel: Add Samsung S6E3FC2X01 DDIC with panel")
No issue/bug to fix here, it's just style. Please drop.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-11-06 10:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-06 10:36 [PATCH] dt-bindings: panel: s6e3fc2x01: Sort and remove unnecessary properties David Heidelberg via B4 Relay
2025-11-06 10:46 ` Krzysztof Kozlowski [this message]
2025-11-06 10:56 ` David Heidelberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=530695ab-109a-4dd4-968b-e8624c53238d@kernel.org \
--to=krzk@kernel.org \
--cc=airlied@gmail.com \
--cc=conor+dt@kernel.org \
--cc=david@ixit.cz \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jesszhan0024@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=phone-devel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox