devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Michal Simek <monstr@monstr.eu>
To: Mark Rutland <mark.rutland@arm.com>
Cc: Felipe Balbi <balbi@ti.com>,
	Subbaraya Sundeep Bhatta <subbaraya.sundeep.bhatta@xilinx.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Subbaraya Sundeep Bhatta <sbhatta@xilinx.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH RFC] usb: gadget: Add xilinx axi usb2 device support
Date: Fri, 21 Feb 2014 14:41:03 +0100	[thread overview]
Message-ID: <5307576F.5050506@monstr.eu> (raw)
In-Reply-To: <20140221120454.GD8783@e106331-lin.cambridge.arm.com>

[-- Attachment #1: Type: text/plain, Size: 3598 bytes --]

Hi Mark,

On 02/21/2014 01:04 PM, Mark Rutland wrote:
> 
> On Thu, Feb 20, 2014 at 06:23:13PM +0000, Felipe Balbi wrote:
>> Hi,
>>
>> On Wed, Feb 19, 2014 at 03:10:45PM +0530, Subbaraya Sundeep Bhatta wrote:
>>> This patch adds xilinx axi usb2 device driver support
>>>
>>> Signed-off-by: Subbaraya Sundeep Bhatta <sbhatta@xilinx.com>
>>> ---
>>>  .../devicetree/bindings/usb/xilinx_usb.txt         |   21 +
>>>  drivers/usb/gadget/Kconfig                         |   14 +
>>>  drivers/usb/gadget/Makefile                        |    1 +
>>>  drivers/usb/gadget/xilinx_udc.c                    | 2045 ++++++++++++++++++++
>>>  4 files changed, 2081 insertions(+), 0 deletions(-)
>>>  create mode 100644 Documentation/devicetree/bindings/usb/xilinx_usb.txt
>>>  create mode 100644 drivers/usb/gadget/xilinx_udc.c
>>>
>>> diff --git a/Documentation/devicetree/bindings/usb/xilinx_usb.txt b/Documentation/devicetree/bindings/usb/xilinx_usb.txt
>>> new file mode 100644
>>> index 0000000..acf03ab
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/usb/xilinx_usb.txt
>>> @@ -0,0 +1,21 @@
>>> +Xilinx AXI USB2 device controller
>>> +
>>> +Required properties:
>>> +- compatible		: Should be "xlnx,axi-usb2-device-4.00.a"
> 
> Is "axi-usb2-device" the official device name?

It is the name of IP which Xilinx have and we are using names in this format.


>>> +- reg			: Physical base address and size of the Axi USB2
>>> +			  device registers map.
>>> +- interrupts		: Property with a value describing the interrupt
>>> +			  number.
> 
> Does the device only have a single interrupt?

I believe so.


>>> +- interrupt-parent	: Must be core interrupt controller
> 
> Is this strictly necessary?

I am not sure what do you mean by that. If you mean that interrupt-parent
can be written to the root of DTS file then we can setup system with more
interrupt controllers that's why it is required.

If we can point to standard interrupt description then please point me to
exact description you would like to see here and we can change it.


>>> +- xlnx,include-dma	: Must be 1 or 0 based on whether DMA is included
>>> +			  in IP or not.
> 
> Perhaps xlnx,has-builtin-dma would better describe this?

No opinion.

>>> +
>>> +Example:
>>> + 		axi-usb2-device@42e00000 {
>>> +                        compatible = "xlnx,axi-usb2-device-4.00.a";
>>> +                        interrupt-parent = <0x1>;
>>> +                        interrupts = <0x0 0x39 0x1>;
>>> +                        reg = <0x42e00000 0x10000>;
>>> +                        xlnx,include-dma = <0x1>;
>>> +                };
>>> +
>>
>> you need to Cc devicetree@vger.kernel.org for this.
> 
> Cheers Filipe; thanks for adding us to Cc :)
> 

Sundeep with CC devicetree list in next patch version.

>>> +	/* Map the registers */
>>> +	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>>> +	udc->base_address = devm_ioremap_nocache(&pdev->dev, res->start,
>>> +						 resource_size(res));
>>
>> use devm_ioremap_resource() instead.
> 
> Also, res might be NULL. You should check that before dereferencing it.

yes it is necessary for both cases with devm_ioremap_nocache
or with devm_ioremap_resource.

Thanks,
Michal

-- 
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 263 bytes --]

  reply	other threads:[~2014-02-21 13:41 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <774153d4-d33f-4bb4-813b-582762bc3af9@TX2EHSMHS021.ehs.local>
     [not found] ` <774153d4-d33f-4bb4-813b-582762bc3af9-8XeO8fnFoNFnw48GICbVzrjjLBE8jN/0@public.gmane.org>
2014-02-20 18:23   ` [PATCH RFC] usb: gadget: Add xilinx axi usb2 device support Felipe Balbi
     [not found]     ` <20140220182257.GF23217-HgARHv6XitL9zxVx7UNMDg@public.gmane.org>
2014-02-21  6:38       ` Michal Simek
2014-02-21 16:04         ` Greg Kroah-Hartman
     [not found]           ` <20140221160442.GA17506-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2014-02-21 16:04             ` Michal Simek
     [not found]               ` <5307790A.4050806-pSz03upnqPeHXe+LvDLADg@public.gmane.org>
2014-02-21 16:12                 ` SPDX-License-Identifier (was: Re: [PATCH RFC] usb: gadget: Add xilinx axi usb2 device support) Felipe Balbi
     [not found]                   ` <20140221161246.GM31902-HgARHv6XitL9zxVx7UNMDg@public.gmane.org>
2014-02-21 16:18                     ` SPDX-License-Identifier Michal Simek
     [not found]                       ` <53077C5F.9000407-pSz03upnqPeHXe+LvDLADg@public.gmane.org>
2014-02-21 16:20                         ` SPDX-License-Identifier Felipe Balbi
2014-02-21 16:56                           ` SPDX-License-Identifier Greg Kroah-Hartman
2014-02-21 17:26                             ` SPDX-License-Identifier Michal Simek
     [not found]                               ` <53078C30.7060703-pSz03upnqPeHXe+LvDLADg@public.gmane.org>
2014-02-21 17:57                                 ` SPDX-License-Identifier Greg Kroah-Hartman
2014-02-21 19:01                                   ` SPDX-License-Identifier Theodore Ts'o
2014-02-24 10:12                                     ` SPDX-License-Identifier Michal Simek
     [not found]                                       ` <530B1B25.5090601-pSz03upnqPeHXe+LvDLADg@public.gmane.org>
2014-02-24 13:41                                         ` SPDX-License-Identifier Theodore Ts'o
2014-02-24 14:03                                           ` SPDX-License-Identifier Michal Simek
     [not found]                                             ` <530B512D.8090308-pSz03upnqPeHXe+LvDLADg@public.gmane.org>
2014-02-24 14:26                                               ` SPDX-License-Identifier Greg Kroah-Hartman
2014-02-25 12:10                                                 ` SPDX-License-Identifier One Thousand Gnomes
2014-02-25 12:25                                                   ` SPDX-License-Identifier Geert Uytterhoeven
2015-02-02 15:43                         ` SPDX-License-Identifier Stefan Roese
     [not found]                           ` <54CF9B12.2070807-ynQEQJNshbs@public.gmane.org>
2015-02-02 16:06                             ` SPDX-License-Identifier Greg Kroah-Hartman
     [not found]                               ` <20150202160622.GA9852-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2015-02-04 16:41                                 ` SPDX-License-Identifier Stefan Roese
     [not found]                                   ` <54D24BA4.3070509-ynQEQJNshbs@public.gmane.org>
2015-02-05  4:21                                     ` SPDX-License-Identifier Theodore Ts'o
2015-02-05  6:41                                     ` SPDX-License-Identifier Greg Kroah-Hartman
2015-02-25 21:49                                       ` SPDX-License-Identifier Pavel Machek
2015-02-25 22:00                                         ` SPDX-License-Identifier Felipe Balbi
2015-02-26 21:49                                           ` SPDX-License-Identifier Pavel Machek
2015-02-26 10:26                                         ` SPDX-License-Identifier One Thousand Gnomes
2015-02-26 13:39                                           ` SPDX-License-Identifier Theodore Ts'o
2015-02-26 21:53                                           ` SPDX-License-Identifier Pavel Machek
2015-02-05 11:49                                     ` SPDX-License-Identifier One Thousand Gnomes
2014-02-21 16:23               ` [PATCH RFC] usb: gadget: Add xilinx axi usb2 device support Greg Kroah-Hartman
2014-03-26 10:07       ` sundeep subbaraya
2014-04-15 17:18         ` Felipe Balbi
2014-04-15 17:55           ` Alan Stern
     [not found]             ` <Pine.LNX.4.44L0.1404151345580.1310-100000-IYeN2dnnYyZXsRXLowluHWD2FQJk+8+b@public.gmane.org>
2014-04-16  4:39               ` Felipe Balbi
2014-02-21 11:27     ` Subbaraya Sundeep Bhatta
2014-02-21 15:39       ` Felipe Balbi
     [not found]         ` <20140221153905.GE31902-HgARHv6XitL9zxVx7UNMDg@public.gmane.org>
2014-03-10 13:36           ` sundeep subbaraya
2014-03-10 18:44             ` Felipe Balbi
2014-02-21 12:04     ` Mark Rutland
2014-02-21 13:41       ` Michal Simek [this message]
2014-02-21 13:57         ` Mark Rutland
2014-02-21 14:06           ` Michal Simek
2014-02-21 15:42         ` Felipe Balbi
     [not found]           ` <20140221154244.GG31902-HgARHv6XitL9zxVx7UNMDg@public.gmane.org>
2014-02-21 15:51             ` Michal Simek
2014-02-21 16:00               ` Felipe Balbi
     [not found]               ` <530775EB.6030004-pSz03upnqPeHXe+LvDLADg@public.gmane.org>
2014-02-21 16:15                 ` Arnd Bergmann
     [not found]       ` <20140221120454.GD8783-NuALmloUBlrZROr8t4l/smS4ubULX0JqMm0uRHvK7Nw@public.gmane.org>
2014-02-21 15:41         ` Felipe Balbi
2014-02-21 16:13           ` Mark Rutland

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5307576F.5050506@monstr.eu \
    --to=monstr@monstr.eu \
    --cc=balbi@ti.com \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=sbhatta@xilinx.com \
    --cc=subbaraya.sundeep.bhatta@xilinx.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).