From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Ben Dooks <ben.dooks@codethink.co.uk>
Cc: balbi@ti.com, linux-usb@vger.kernel.org, robh+dt@kernel.org,
pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
grant.likely@linaro.org, devicetree@vger.kernel.org,
gregkh@linuxfoundation.org, linux-sh@vger.kernel.org,
valentine.barshak@cogentembedded.com, rob@landley.net,
linux-doc@vger.kernel.org
Subject: Re: [PATCH] phy-rcar-gen2-usb: add device tree support
Date: Thu, 27 Feb 2014 20:34:42 +0400 [thread overview]
Message-ID: <530F6922.3060101@cogentembedded.com> (raw)
In-Reply-To: <530F626C.5020900@codethink.co.uk>
On 27-02-2014 20:06, Ben Dooks wrote:
>> Add support of the device tree probing for the Renesas R-Car generation 2 SoCs
>> documenting the device tree binding as necessary.
> You've popped in some fixes for the driver probe in here as well.
No, I didn't -- it's all the result of not using devm_clk_get().
[...]
>> @@ -177,13 +210,19 @@ static int rcar_gen2_usb_phy_probe(struc
[...]
>> - clk = devm_clk_get(dev, "usbhs");
>> + if (np)
>> + clk = of_clk_get_by_name(np, "usbhs");
>> + else
>> + clk = clk_get(dev, "usbhs");
> Can be removed, just add a clock-name of usbhs in the device node.
Ah, I haven't figured out I should check clk_get() first... Yes, I'm
adding the "clock-names" prop.
WBR, Sergei
prev parent reply other threads:[~2014-02-27 16:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-27 0:12 [PATCH] phy-rcar-gen2-usb: add device tree support Sergei Shtylyov
2014-02-27 12:57 ` Ben Dooks
[not found] ` <530F3637.5050000-4yDnlxn2s6sWdaTGBSpHTA@public.gmane.org>
2014-02-27 15:50 ` Sergei Shtylyov
[not found] ` <201402270312.51588.sergei.shtylyov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
2014-02-27 15:56 ` Mark Rutland
[not found] ` <20140227155657.GD8647-NuALmloUBlrZROr8t4l/smS4ubULX0JqMm0uRHvK7Nw@public.gmane.org>
2014-02-28 22:23 ` Sergei Shtylyov
2014-02-27 16:06 ` Ben Dooks
2014-02-27 16:34 ` Sergei Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=530F6922.3060101@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=balbi@ti.com \
--cc=ben.dooks@codethink.co.uk \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=grant.likely@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-doc@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=rob@landley.net \
--cc=robh+dt@kernel.org \
--cc=valentine.barshak@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).