Re: [PATCH 4/6] phy-rcar-usb-gen2: add device tree support

[Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>]

Hello.

On 02/27/2014 07:03 PM, Ben Dooks wrote:

>>>>> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
>>>>> Reviewed-by: Ian Molton <ian.molton@codethink.co.uk>
>>>>> ---
>>>>> Cc: linux-usb@vger.kernel.org (open list:USB PHY LAYER)
>>>>> Cc: linux-sh@vger.kernel.org (open list:ARM/SHMOBILE ARM...)
>>>>> Cc: Magnus Damm <magnus.damm@gmail.com> (supporter:ARM/SHMOBILE ARM...)
>>>>> Cc: Simon Horman <horms@verge.net.au> (supporter:ARM/SHMOBILE ARM...)
>>>>> Cc: devicetree@vger.kernel.org (open list:OPEN FIRMWARE AND...)
>>>>> ---
>>>>>   drivers/usb/phy/phy-rcar-gen2-usb.c | 35
>>>>> ++++++++++++++++++++++++++++++-----
>>>>>   1 file changed, 30 insertions(+), 5 deletions(-)

>>>>> diff --git a/drivers/usb/phy/phy-rcar-gen2-usb.c
>>>>> b/drivers/usb/phy/phy-rcar-gen2-usb.c
>>>>> index db3ab34..906b74b 100644
>>>>> --- a/drivers/usb/phy/phy-rcar-gen2-usb.c
>>>>> +++ b/drivers/usb/phy/phy-rcar-gen2-usb.c
>>>> [...]
>>>>> @@ -203,16 +212,31 @@ static int rcar_gen2_usb_phy_probe(struct
>>>>> platform_device *pdev)
>>>> [...]
>>>>> +    if (of_id) {
>> [...]
>>>>> +        int len = 0;
>>>>> +
>>>>> +        if (of_get_property(dev->of_node, "renesas,usb0-hs", &len))
>>>>> +            priv->ugctrl2 = USBHS_UGCTRL2_USB0_HS;
>>>>> +        else
>>>>> +            priv->ugctrl2 = USBHS_UGCTRL2_USB0_PCI;
>>>>> +
>>>>> +        if (of_get_property(dev->of_node, "renesas,usb2-ss", &len))
>>>>> +            priv->ugctrl2 |= USBHS_UGCTRL2_USB2_SS;

>>>>     Where is the bindings file you document these properties in?

>>> Should have been in another patch in the series.

>>     I didn't see it.

> I thought it went out, I will need to go check.

    It turned out that I'd already replied to that email that I had seen all 6 
patches but not the binding patch, so most probably it didn't went out that 
time. I've seen the latter patch (just not posted to linux-usb), so no problem 
here.

WBR, Sergei