Re: [PATCH 06/12] phy: omap: Select OMAP_OCP2SCP bus driver

[Roger Quadros <rogerq@ti.com>]

On 03/03/2014 08:52 PM, Tony Lindgren wrote:
> * Roger Quadros <rogerq@ti.com> [140303 07:11]:
>> The OMAP_USB2 and OMAP_PIP3 phy devices will not be
>> detected if the OMAP_OCP2SCP driver is not present.
>> So select it.
> 
> Selecting drivers like this will easily lead into missing
> dependencies. Especially it's bad for tristate driver
> options that people may want to have as loadable modules.
> 
> How about instead depends on OMAP_OCP2SCP?

OK, 'depends' seems fine.

cheers,
-roger

> 
>  
>> Signed-off-by: Roger Quadros <rogerq@ti.com>
>> ---
>>  drivers/phy/Kconfig | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig
>> index 2f02ec8..afdab3e 100644
>> --- a/drivers/phy/Kconfig
>> +++ b/drivers/phy/Kconfig
>> @@ -44,6 +44,7 @@ config OMAP_USB2
>>  	depends on USB_PHY
>>  	select GENERIC_PHY
>>  	select OMAP_CONTROL_PHY
>> +	select OMAP_OCP2SCP
>>  	help
>>  	  Enable this to support the transceiver that is part of SOC. This
>>  	  driver takes care of all the PHY functionality apart from comparator.
>> @@ -55,6 +56,7 @@ config TI_PIPE3
>>  	depends on ARCH_OMAP2PLUS || COMPILE_TEST
>>  	select GENERIC_PHY
>>  	select OMAP_CONTROL_PHY
>> +	select OMAP_OCP2SCP
>>  	help
>>  	  Enable this to support the PIPE3 PHY that is part of TI SOCs. This
>>  	  driver takes care of all the PHY functionality apart from comparator.
>> -- 
>> 1.8.3.2
>>