From: Eli Billauer <eli.billauer@gmail.com>
To: "Sören Brinkmann" <soren.brinkmann@xilinx.com>
Cc: chris@printf.net, michal.simek@xilinx.com,
linux-mmc@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Mike Looijmans <mike.looijmans@topic.nl>
Subject: Re: [PATCH v2] mmc: sdhci: add quirk for broken write protect detection
Date: Tue, 04 Mar 2014 22:06:31 +0200 [thread overview]
Message-ID: <53163247.8000904@gmail.com> (raw)
In-Reply-To: <74003aec-1707-4f43-b947-df148d573fa1@TX2EHSMHS038.ehs.local>
Hello Sören,
wp-inverted solves the practical problem indeed, and fools the driver
into thinking that the card has an inverted write protection sensor, and
the logic zero that it finds in the hardware register means that the
card isn't write protected.
I'm insisting on this patch, because I think that the device tree should
describe the hardware as it is, and not fool the driver into behaving
the way we want it to. These tricks always bite back later on.
Regards,
Eli
On 04/03/14 21:26, Sören Brinkmann wrote:
> Hi Eli,
>
> On Sun, 2014-03-02 at 01:20PM +0200, Eli Billauer wrote:
>
>> The write protection signal is absent on a board based upon Xilinx' Zynq
>> processor ("ZyBo"). This leads the kernel to think that the MicroSD card is
>> write protected, and causes a kernel panic during boot, as root fails to
>> mount RW.
>>
> I talked to some people here at Xilinx. According to them, you have the
> option to pin out the WP signal, which would mean the board needs to
> tie/connect the signal properly. Or, if you select to not pin out the WP
> signal, it should be tied to 0 within the chip.
> Currently, I have some doubts that is the case, since Mike reported the
> same issue, but would you mind double checking?
> In theory the signal should default to logic zero which would at most
> require to add the, already existing, 'wp-inverted' quirk when using
> micro-sd on Zynq.
>
> Thanks,
> Sören
>
>
>
>
next prev parent reply other threads:[~2014-03-04 20:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-02 11:20 [PATCH v2] mmc: sdhci: add quirk for broken write protect detection Eli Billauer
2014-03-04 19:26 ` Sören Brinkmann
2014-03-04 20:06 ` Eli Billauer [this message]
2014-03-04 21:00 ` Sören Brinkmann
2014-03-06 13:31 ` Mike Looijmans
2014-03-06 16:42 ` Sören Brinkmann
[not found] ` <ad0a3559-a687-4f51-b284-f515372cfad2-+Ck8Kgl/v09ZbvUCbuG1mrjjLBE8jN/0@public.gmane.org>
2014-03-20 12:26 ` Michal Simek
2014-03-20 12:39 ` Eli Billauer
2014-03-20 13:04 ` Mike Looijmans
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53163247.8000904@gmail.com \
--to=eli.billauer@gmail.com \
--cc=chris@printf.net \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=mike.looijmans@topic.nl \
--cc=soren.brinkmann@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).