devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Pavel Machek <pavel@denx.de>,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	galak@codeaurora.org, ijc+devicetree@hellion.org.uk,
	mark.rutland@arm.com, pawel.moll@arm.com, robh+dt@kernel.org,
	dinguyen@altera.com
Subject: Re: [PATCH] dts: add support for MMC on socfpga boards
Date: Thu, 06 Mar 2014 01:30:36 +0300	[thread overview]
Message-ID: <5317A58C.1080703@cogentembedded.com> (raw)
In-Reply-To: <20140305162350.GA3674@pollux.denx.de>

Hello.

On 03/05/2014 07:23 PM, Pavel Machek wrote:

> Add DTS binding for MMC on socfpga boards. Tested on Sockit.

> Signed-off-by: Pavel Machek <pavel@denx.de>

> diff --git a/arch/arm/boot/dts/socfpga.dtsi b/arch/arm/boot/dts/socfpga.dtsi
> index 537f1a5..cad7526 100644
> --- a/arch/arm/boot/dts/socfpga.dtsi
> +++ b/arch/arm/boot/dts/socfpga.dtsi
> @@ -521,6 +521,23 @@
>   			reg-io-width = <4>;
>   		};
>
> +		mmc: dwmmc0@ff704000 {

    ePAPR standard [1] tells us in section 2.2.2:

The name of a node should be somewhat generic, reflecting the function of the 
device and not its 3 precise programming model.

     So, please name the node just "mmc@ff704000". You can choose whatever 
label you like.

[1] http://www.power.org/resources/downloads/Power_ePAPR_APPROVED_v1.0.pdf

WBR, Sergei

      parent reply	other threads:[~2014-03-05 22:30 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-05 16:23 [PATCH] dts: add support for MMC on socfpga boards Pavel Machek
     [not found] ` <20140305162350.GA3674-E0MFdw8UecLj/ljBK/0BTg@public.gmane.org>
2014-03-05 16:23   ` Dinh Nguyen
2014-03-05 22:30 ` Sergei Shtylyov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5317A58C.1080703@cogentembedded.com \
    --to=sergei.shtylyov@cogentembedded.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dinguyen@altera.com \
    --cc=galak@codeaurora.org \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=pavel@denx.de \
    --cc=pawel.moll@arm.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).