Re: [PATCH] dts: add support for MMC on socfpga boards

Re: [PATCH] dts: add support for MMC on socfpga boards

[Dinh Nguyen]

On Wed, 2014-03-05 at 17:23 +0100, ZY - pavel wrote:
> Add DTS binding for MMC on socfpga boards. Tested on Sockit.
>     
> Signed-off-by: Pavel Machek <pavel-ynQEQJNshbs@public.gmane.org>
> 
> diff --git a/arch/arm/boot/dts/socfpga.dtsi b/arch/arm/boot/dts/socfpga.dtsi
> index 537f1a5..cad7526 100644
> --- a/arch/arm/boot/dts/socfpga.dtsi
> +++ b/arch/arm/boot/dts/socfpga.dtsi
> @@ -521,6 +521,23 @@
>  			reg-io-width = <4>;
>  		};
>  
> +		mmc: dwmmc0@ff704000 {
> +			compatible = "snps,dw-mshc";
> +			reg = <0xff704000 0x1000>;
> +			interrupts = <0 139 4>;
> +			clock-frequency = <12500000>; /*12.5 MHz*/
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +			num-slots = <1>;
> +			supports-highspeed;
> +			broken-cd;
> +			fifo-depth = <0x400>;
> +			slot@0 {
> +				reg = <0>;
> +				bus-width = <4>;
> +			};
> +		};
> +
>  		rstmgr@ffd05000 {
>  			compatible = "altr,rst-mgr";
>  			reg = <0xffd05000 0x1000>;
> 

This is already queued in Chris Ball's MMC tree.

Thanks,
Dinh


--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] dts: add support for MMC on socfpga boards

[Pavel Machek]

Add DTS binding for MMC on socfpga boards. Tested on Sockit.
    
Signed-off-by: Pavel Machek <pavel-ynQEQJNshbs@public.gmane.org>

diff --git a/arch/arm/boot/dts/socfpga.dtsi b/arch/arm/boot/dts/socfpga.dtsi
index 537f1a5..cad7526 100644
--- a/arch/arm/boot/dts/socfpga.dtsi
+++ b/arch/arm/boot/dts/socfpga.dtsi
@@ -521,6 +521,23 @@
 			reg-io-width = <4>;
 		};
 
+		mmc: dwmmc0@ff704000 {
+			compatible = "snps,dw-mshc";
+			reg = <0xff704000 0x1000>;
+			interrupts = <0 139 4>;
+			clock-frequency = <12500000>; /*12.5 MHz*/
+			#address-cells = <1>;
+			#size-cells = <0>;
+			num-slots = <1>;
+			supports-highspeed;
+			broken-cd;
+			fifo-depth = <0x400>;
+			slot@0 {
+				reg = <0>;
+				bus-width = <4>;
+			};
+		};
+
 		rstmgr@ffd05000 {
 			compatible = "altr,rst-mgr";
 			reg = <0xffd05000 0x1000>;
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] dts: add support for MMC on socfpga boards

[Sergei Shtylyov]

Hello.

On 03/05/2014 07:23 PM, Pavel Machek wrote:

> Add DTS binding for MMC on socfpga boards. Tested on Sockit.

> Signed-off-by: Pavel Machek <pavel@denx.de>

> diff --git a/arch/arm/boot/dts/socfpga.dtsi b/arch/arm/boot/dts/socfpga.dtsi
> index 537f1a5..cad7526 100644
> --- a/arch/arm/boot/dts/socfpga.dtsi
> +++ b/arch/arm/boot/dts/socfpga.dtsi
> @@ -521,6 +521,23 @@
>   			reg-io-width = <4>;
>   		};
>
> +		mmc: dwmmc0@ff704000 {

    ePAPR standard [1] tells us in section 2.2.2:

The name of a node should be somewhat generic, reflecting the function of the 
device and not its 3 precise programming model.

     So, please name the node just "mmc@ff704000". You can choose whatever 
label you like.

[1] http://www.power.org/resources/downloads/Power_ePAPR_APPROVED_v1.0.pdf

WBR, Sergei