devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tero Kristo <t-kristo@ti.com>
To: Tony Lindgren <tony@atomide.com>
Cc: linux-omap@vger.kernel.org, nm@ti.com, mturquette@linaro.org,
	paul@pwsan.com, linux-arm-kernel@lists.infradead.org,
	devicetree@vger.kernel.org
Subject: Re: [PATCHv2 13/14] ARM: OMAP24xx: clock: remove legacy clock data
Date: Thu, 6 Mar 2014 15:39:30 +0200	[thread overview]
Message-ID: <53187A92.2000809@ti.com> (raw)
In-Reply-To: <20140305181045.GH4983@atomide.com>

On 03/05/2014 08:10 PM, Tony Lindgren wrote:
> * Tony Lindgren <tony@atomide.com> [140305 09:12]:
>> * Tero Kristo <t-kristo@ti.com> [140305 00:17]:
>>> On 03/04/2014 11:28 PM, Tony Lindgren wrote:
>>>> * Tero Kristo <t-kristo@ti.com> [140304 10:58]:
>>>>> On 03/04/2014 07:32 PM, Tony Lindgren wrote:
>>>>>> * Tero Kristo <t-kristo@ti.com> [140304 01:22]:
>>>>>>> This is no longer needed as clock data is provided through DT.
>>>>>>
>>>>>> Looks like there's a new error even before applying this patch in
>>>>>> the series as I'm now getting the following oops on n8x0. So cannot
>>>>>> test this patch yet.
>>>>>
>>>>> Is this with OMAP2 only boot?
>>>>
>>>> Yeah that's with omap2 only.
>>>
>>> That explains it, as previous series was never boot tested in omap2
>>> only config (due to build issues.)
>>>
>>> I just force pushed the branch with the below additional patch, can
>>> you check if it works now?
>>
>> Yes seems to work with that thanks. And with the omap2 legacy clock
>> data removed too, it boots fine on n8x0 and 2430sdp.
>>
>> I suggest you drop the omap3 legacy data patch from this branch
>> as it's not omap2 related and cannot be done yet. Then try to get
>> acks from Paul. And if there are no issues, it seems Mike could take
>> the whole branch as it seems to merge just fine with what I have
>> queued. So for all the patches except for the omap3 legacy data
>> removal, feel free to add:
>>
>> Acked-by: Tony Lindgren <tony@atomide.com>
>
> Found one randconfig error with this series when CONFIG_ARCH_OMAP2
> is not set:
>
> /drivers/clk/ti/dpll.c:273: undefined reference to `omap2xxx_clkt_dpllcore_init'
> drivers/clk/ti/dpll.c:311: undefined reference to `clkhwops_omap2xxx_dpll'

Yeah, this is in this series. Force pushed a minor update to patch #4 to 
fix this.

I can repost the series if Mike or Paul or someone requests this.

-Tero

>
> It's also possible the error is the PRM clean up series, but probably
> in this series based drivers/clk/ti/dpll.c path.
>
> Regards,
>
> Tony
>


  reply	other threads:[~2014-03-06 13:39 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-04  9:18 [PATCHv2 00/14]: ARM: OMAP2: clock DT conversion Tero Kristo
2014-03-04  9:18 ` [PATCHv2 01/14] ARM: OMAP2: convert sys_ck and osc_ck to standard clock types Tero Kristo
2014-03-04  9:18 ` [PATCHv2 02/14] ARM: OMAP2420: clock: get rid of fixed-div property use Tero Kristo
2014-03-04  9:18 ` [PATCHv2 03/14] CLK: TI: DPLL: simplify autoidle register detection logic Tero Kristo
2014-03-04  9:18 ` [PATCHv2 04/14] CLK: TI: DPLL: add support for omap2 core dpll Tero Kristo
2014-03-04  9:18 ` [PATCHv2 05/14] CLK: TI: APLL: add support for omap2 aplls Tero Kristo
2014-03-04  9:18 ` [PATCHv2 06/14] CLK: TI: gate: fixed DT binding documentation bugs Tero Kristo
2014-03-04  9:18 ` [PATCHv2 07/14] CLK: TI: interface: add support for omap2430 specific interface clock Tero Kristo
2014-03-04  9:18 ` [PATCHv2 08/14] CLK: TI: OMAP2: add clock init support Tero Kristo
2014-03-04  9:18 ` [PATCHv2 09/14] ARM: OMAP2: PRM: add support for OMAP2 specific clock providers Tero Kristo
2014-03-04  9:18 ` [PATCHv2 10/14] ARM: dts: omap2 clock data Tero Kristo
2014-03-04  9:18 ` [PATCHv2 11/14] ARM: OMAP2: clock: add DT boot support for cpufreq_ck Tero Kristo
2014-03-04  9:18 ` [PATCHv2 12/14] ARM: OMAP2: clock: use DT clock boot if available Tero Kristo
     [not found] ` <1393924700-6510-1-git-send-email-t-kristo-l0cyMroinI0@public.gmane.org>
2014-03-04  9:18   ` [PATCHv2 13/14] ARM: OMAP24xx: clock: remove legacy clock data Tero Kristo
2014-03-04 17:32     ` Tony Lindgren
2014-03-04 18:54       ` Tero Kristo
2014-03-04 21:28         ` Tony Lindgren
2014-03-05  8:14           ` Tero Kristo
2014-03-05 17:08             ` Tony Lindgren
     [not found]               ` <20140305170857.GD4983-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2014-03-05 18:10                 ` Tony Lindgren
2014-03-06 13:39                   ` Tero Kristo [this message]
2014-03-04  9:18   ` [PATCHv2 14/14] ARM: OMAP3: " Tero Kristo
2014-03-04 17:32     ` Tony Lindgren
2014-03-05  7:32       ` Tero Kristo
2014-03-05 16:28         ` Tony Lindgren
2014-05-19 14:21 ` [PATCHv2 00/14]: ARM: OMAP2: clock DT conversion Tero Kristo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53187A92.2000809@ti.com \
    --to=t-kristo@ti.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=mturquette@linaro.org \
    --cc=nm@ti.com \
    --cc=paul@pwsan.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).