devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Warren <swarren@wwwdotorg.org>
To: Eduardo Valentin <eduardo.valentin@ti.com>
Cc: Wei Ni <wni@nvidia.com>, Zhang Rui <rui.zhang@intel.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Kumar Gala <galak@codeaurora.org>
Subject: thermal-zones DT node bound by name rather than compatible property
Date: Thu, 06 Mar 2014 10:57:01 -0700	[thread overview]
Message-ID: <5318B6ED.3060104@wwwdotorg.org> (raw)

Commit 4e5e4705bf69 "thermal: introduce device tree parser" introduced
the text below into Documentation/devicetree/bindings/thermal/thermal.txt:

> * The thermal-zones node
> 
> The "thermal-zones" node is a container for all thermal zone nodes. It shall
> contain only sub-nodes describing thermal zones as in the section
> "Thermal zone nodes". The "thermal-zones" node appears under "/".

This implies that software must find the thermal-zones node by node
name. Node names aren't supposed to be significant in DT. Rather,
software is supposed to bind to a node by searching for all nodes with a
particular value in the compatible property. While there are some legacy
counter-examples such as /aliases, /chosen, and /cpus, I don't think we
should propagate any more of these in new bindings.

Can this mistake in the binding definition be rectified, or is it too late?

                 reply	other threads:[~2014-03-06 17:57 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5318B6ED.3060104@wwwdotorg.org \
    --to=swarren@wwwdotorg.org \
    --cc=devicetree@vger.kernel.org \
    --cc=eduardo.valentin@ti.com \
    --cc=galak@codeaurora.org \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=pawel.moll@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=rui.zhang@intel.com \
    --cc=wni@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).