From: Sylwester Nawrocki <sylvester.nawrocki@gmail.com>
To: Philipp Zabel <philipp.zabel@gmail.com>
Cc: Sylwester Nawrocki <s.nawrocki@samsung.com>,
linux-media@vger.kernel.org, devicetree@vger.kernel.org,
Mark Rutland <mark.rutland@arm.com>,
linux-samsung-soc@vger.kernel.org, a.hajda@samsung.com,
kyungmin.park@samsung.com, Rob Herring <robh+dt@kernel.org>,
Kumar Gala <galak@codeaurora.org>,
Kukjin Kim <kgene.kim@samsung.com>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v6 01/10] Documentation: dt: Add binding documentation for S5K6A3 image sensor
Date: Thu, 06 Mar 2014 21:15:42 +0100 [thread overview]
Message-ID: <5318D76E.80203@gmail.com> (raw)
In-Reply-To: <CA+gwMcc7sLp0N5oyCYf-121AzS8KsRdNsvY3DJ7p3z=yVLrBdw@mail.gmail.com>
Hi Phillip,
On 03/06/2014 07:08 PM, Philipp Zabel wrote:
>> +++ b/Documentation/devicetree/bindings/media/samsung-s5k6a3.txt
>> > @@ -0,0 +1,33 @@
>> > +Samsung S5K6A3(YX) raw image sensor
>> > +---------------------------------
>> > +
>> > +S5K6A3(YX) is a raw image sensor with MIPI CSI-2 and CCP2 image data interfaces
>> > +and CCI (I2C compatible) control bus.
>> > +
>> > +Required properties:
>> > +
>> > +- compatible : "samsung,s5k6a3";
>> > +- reg : I2C slave address of the sensor;
>> > +- svdda-supply : core voltage supply;
>> > +- svddio-supply : I/O voltage supply;
>> > +- afvdd-supply : AF (actuator) voltage supply;
>> > +- gpios : specifier of a GPIO connected to the RESET pin;
>
> Please use 'reset-gpios' for GPIOs connected to reset pins.
I would prefer to keep it as is, I'm not adding a new driver in this
series, just the binding documentation and doing some refactoring.
So if I changed this now, the driver would need to be messed up with
an additional code to support both 'gpios' and 'reset-gpios'. Are
there any serious reasons to use this specific name ? It's not
related to the reset signal DT bindings, is it ?
--
Regards,
Sylwester
next prev parent reply other threads:[~2014-03-06 20:15 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-06 16:20 [PATCH v6 00/10] Add device tree support for Exynos4 camera interface Sylwester Nawrocki
2014-03-06 16:20 ` [PATCH v6 01/10] Documentation: dt: Add binding documentation for S5K6A3 image sensor Sylwester Nawrocki
2014-03-06 18:08 ` Philipp Zabel
2014-03-06 20:15 ` Sylwester Nawrocki [this message]
2014-03-06 16:20 ` [PATCH v6 02/10] Documentation: dt: Add binding documentation for S5C73M3 camera Sylwester Nawrocki
2014-03-06 16:20 ` [PATCH v6 03/10] Documentation: devicetree: Update Samsung FIMC DT binding Sylwester Nawrocki
2014-03-11 12:30 ` Laurent Pinchart
2014-03-11 13:38 ` Sylwester Nawrocki
2014-03-11 14:58 ` Laurent Pinchart
2014-03-11 16:00 ` [PATCH v7 3/10] " Sylwester Nawrocki
2014-03-11 16:20 ` Laurent Pinchart
2014-03-11 16:30 ` Sylwester Nawrocki
2014-03-11 16:34 ` [PATCH v8 " Sylwester Nawrocki
2014-03-11 16:38 ` Laurent Pinchart
2014-03-12 15:41 ` Mauro Carvalho Chehab
2014-03-18 10:02 ` Mark Rutland
2014-03-18 11:31 ` Sylwester Nawrocki
2014-03-06 16:20 ` [PATCH v6 04/10] V4L: Add driver for s5k6a3 image sensor Sylwester Nawrocki
2014-03-06 16:20 ` [PATCH v6 05/10] V4L: s5c73m3: Add device tree support Sylwester Nawrocki
2014-03-18 10:05 ` Arnd Bergmann
2014-03-18 11:07 ` Sylwester Nawrocki
2014-03-06 16:20 ` [PATCH v6 06/10] exynos4-is: Use external s5k6a3 sensor driver Sylwester Nawrocki
2014-03-06 16:20 ` [PATCH v6 07/10] exynos4-is: Add clock provider for the SCLK_CAM clock outputs Sylwester Nawrocki
2014-03-06 16:20 ` [PATCH v6 08/10] exynos4-is: Add support for asynchronous subdevices registration Sylwester Nawrocki
2014-03-06 16:20 ` [PATCH v6 09/10] ARM: dts: Add rear camera nodes for Exynos4412 TRATS2 board Sylwester Nawrocki
2014-03-07 10:07 ` Sylwester Nawrocki
2014-03-06 16:20 ` [PATCH v6 10/10] ARM: dts: exynos4: Update camera clk provider and s5k6a3 sensor node Sylwester Nawrocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5318D76E.80203@gmail.com \
--to=sylvester.nawrocki@gmail.com \
--cc=a.hajda@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=kgene.kim@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=philipp.zabel@gmail.com \
--cc=robh+dt@kernel.org \
--cc=s.nawrocki@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).