From mboxrd@z Thu Jan 1 00:00:00 1970 From: srinivas kandagatla Subject: Re: [PATCH v2 3/5] pinctrl: st: Enhance the controller to manage unavailable registers Date: Fri, 7 Mar 2014 11:26:49 +0000 Message-ID: <5319ACF9.4040504@st.com> References: <1394185272-26054-1-git-send-email-maxime.coquelin@st.com> <1394185272-26054-4-git-send-email-maxime.coquelin@st.com> <5319A263.6020201@st.com> <5319AD5C.7050301@st.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <5319AD5C.7050301-qxv4g6HH51o@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Maxime Coquelin , Rob Landley , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Russell King , Stuart Menefy , Linus Walleij , Giuseppe Cavallaro , linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, kernel-F5mvAk5X5gdBDgjK7y7TUQ@public.gmane.org Cc: lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org List-Id: devicetree@vger.kernel.org On 07/03/14 11:28, Maxime Coquelin wrote: >> > > Problem is that "oe" and "pu" takes -1 in that patch, and these values > will be passed directly to devm_regmap_field_alloc without any check. > > I propose to apply this patch before "pinctrl: st: add pinctrl support > for the STiH407 SoC", and move stih407_flashdata as you recommend. > > Is it fine for you? Am OK with re-ordering, This will also be good for git bisect... :-) Thanks, srini > > Thanks for the review, > Maxime -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html