devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jyri Sarha <jsarha@ti.com>
To: Mark Brown <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
	linux-omap@vger.kernel.org, peter.ujfalusi@ti.com,
	liam.r.girdwood@linux.intel.com, bcousson@baylibre.com,
	detheridge@ti.com
Subject: Re: [PATCH v4] ASoC: tlv320aic31xx: Add basic codec driver implementation
Date: Mon, 10 Mar 2014 21:23:40 +0200	[thread overview]
Message-ID: <531E113C.30106@ti.com> (raw)
In-Reply-To: <531DE2CF.7060708@ti.com>

On 03/10/2014 06:05 PM, Jyri Sarha wrote:
> On 03/10/2014 05:47 PM, Mark Brown wrote:
>> On Mon, Mar 10, 2014 at 03:25:41PM +0200, Jyri Sarha wrote:
>>> On 03/10/2014 02:58 PM, Mark Brown wrote:
>>>> On Mon, Mar 10, 2014 at 10:52:21AM +0200, Jyri Sarha wrote:
> ...
>>
>>> I agreed on not to have it as the default. I can still imagine
>>> couple of reason to have this option around. For instance, if the
>>> board designer decides to pull the bias voltage from outside of the
>>> chip completely, or like in my test setup when I feed the mic input
>>> from a headset output of another device, because I do not have a
>>> microphone around ATM.
>>
>> To repeat what I said first time around in those cases the pin wouldn't
>> be connected at all so why would it ever be enabled?  You're not
>> specifying that it's going to be always enabled at a given voltage.
>>
>
> What ever. My laptop headset output does not seem to mind about bias
> voltage being fed to it. In the first case the pin wouldn't be connected
> so it does not matter. I'll remove the option.
>

Damn, I finally understood what you meant. I removed the explicit route 
to MICBIAS from the codec driver and left it to be added by a machine 
driver. Also removed all references to MIBIAS_OFF DT parameter.

Best regards,
Jyri

  reply	other threads:[~2014-03-10 19:23 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-10  8:52 [PATCH v4] AM43xx-ePOS-EVM audio support with TLV320AIC31XX driver Jyri Sarha
2014-03-10  8:52 ` [PATCH v4] ASoC: tlv320aic31xx: Add basic codec driver implementation Jyri Sarha
2014-03-10  9:39   ` Lokesh Vutla
2014-03-10  9:45     ` Mark Brown
2014-03-10 12:09   ` Mark Rutland
2014-03-10 12:11     ` Mark Brown
2014-03-10 13:15     ` Jyri Sarha
2014-03-10 13:31       ` Mark Rutland
2014-03-10 12:58   ` Mark Brown
     [not found]     ` <20140310125848.GI28112-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2014-03-10 13:25       ` Jyri Sarha
2014-03-10 15:47         ` Mark Brown
2014-03-10 16:05           ` Jyri Sarha
2014-03-10 19:23             ` Jyri Sarha [this message]
2014-03-10  9:13 ` [PATCH v4] AM43xx-ePOS-EVM audio support with TLV320AIC31XX driver Mark Brown
2014-03-10  9:26   ` Jyri Sarha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=531E113C.30106@ti.com \
    --to=jsarha@ti.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=bcousson@baylibre.com \
    --cc=broonie@kernel.org \
    --cc=detheridge@ti.com \
    --cc=devicetree@vger.kernel.org \
    --cc=liam.r.girdwood@linux.intel.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=peter.ujfalusi@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).