From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jyri Sarha Subject: Re: [PATCH v4] ASoC: tlv320aic31xx: Add basic codec driver implementation Date: Mon, 10 Mar 2014 21:23:40 +0200 Message-ID: <531E113C.30106@ti.com> References: <20140310125848.GI28112@sirena.org.uk> <531DBD55.6030008@ti.com> <20140310154744.GJ28112@sirena.org.uk> <531DE2CF.7060708@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <531DE2CF.7060708@ti.com> Sender: linux-omap-owner@vger.kernel.org To: Mark Brown Cc: alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-omap@vger.kernel.org, peter.ujfalusi@ti.com, liam.r.girdwood@linux.intel.com, bcousson@baylibre.com, detheridge@ti.com List-Id: devicetree@vger.kernel.org On 03/10/2014 06:05 PM, Jyri Sarha wrote: > On 03/10/2014 05:47 PM, Mark Brown wrote: >> On Mon, Mar 10, 2014 at 03:25:41PM +0200, Jyri Sarha wrote: >>> On 03/10/2014 02:58 PM, Mark Brown wrote: >>>> On Mon, Mar 10, 2014 at 10:52:21AM +0200, Jyri Sarha wrote: > ... >> >>> I agreed on not to have it as the default. I can still imagine >>> couple of reason to have this option around. For instance, if the >>> board designer decides to pull the bias voltage from outside of the >>> chip completely, or like in my test setup when I feed the mic input >>> from a headset output of another device, because I do not have a >>> microphone around ATM. >> >> To repeat what I said first time around in those cases the pin wouldn't >> be connected at all so why would it ever be enabled? You're not >> specifying that it's going to be always enabled at a given voltage. >> > > What ever. My laptop headset output does not seem to mind about bias > voltage being fed to it. In the first case the pin wouldn't be connected > so it does not matter. I'll remove the option. > Damn, I finally understood what you meant. I removed the explicit route to MICBIAS from the codec driver and left it to be added by a machine driver. Also removed all references to MIBIAS_OFF DT parameter. Best regards, Jyri