From: Lars-Peter Clausen <lars@metafoo.de>
To: Brian Austin <brian.austin@cirrus.com>
Cc: Nicolin Chen <Guangyu.Chen@freescale.com>,
broonie@kernel.org, Paul.Handrigan@cirrus.com,
robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
rob@landley.net, lgirdwood@gmail.com, grant.likely@linaro.org,
devicetree@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org
Subject: Re: [PATCH v2] ASoC: cs42888: Add codec driver support
Date: Tue, 11 Mar 2014 16:55:58 +0100 [thread overview]
Message-ID: <531F320E.70605@metafoo.de> (raw)
In-Reply-To: <alpine.DEB.2.02.1403111026280.3558@heelrod>
On 03/11/2014 04:41 PM, Brian Austin wrote:
>
> On Tue, 11 Mar 2014, Nicolin Chen wrote:
>
>> This patch adds support for the Cirrus Logic CS42888 Audio CODEC that
>> has four 24-bit A/D and eight 24-bit D/A converters.
>>
>> [ CS42888 supports both I2C and SPI control ports. As initial patch,
>> this patch only adds the support for I2C. ]
>>
>> Signed-off-by: Nicolin Chen <Guangyu.Chen@freescale.com>
>> ---
> So WRT the CS42888, this is one device in a series of 2 devices that are
> register compatible with the only difference being that the CS42488 has 2
> extra ADC's. Same die and same DeviceID.
>
> Would it make more sense to submit the driver with the extra ADC's to make
> it feature complete for both devices? Wouldn't be odd to have 2 drivers that
> do the same for 98% of the code.
This should be in one driver. But support for the second device can always
be added in a follow up patch.
- Lars
next prev parent reply other threads:[~2014-03-11 15:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-11 11:19 [PATCH v2] ASoC: cs42888: Add codec driver support Nicolin Chen
2014-03-11 11:30 ` Mark Rutland
2014-03-11 11:11 ` Nicolin Chen
[not found] ` <1394536791-8381-1-git-send-email-Guangyu.Chen-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2014-03-11 15:41 ` Brian Austin
2014-03-11 15:55 ` Lars-Peter Clausen [this message]
2014-03-11 18:46 ` Mark Brown
2014-03-12 1:54 ` Nicolin Chen
2014-03-12 2:05 ` Austin, Brian
2014-03-12 2:03 ` Nicolin Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=531F320E.70605@metafoo.de \
--to=lars@metafoo.de \
--cc=Guangyu.Chen@freescale.com \
--cc=Paul.Handrigan@cirrus.com \
--cc=alsa-devel@alsa-project.org \
--cc=brian.austin@cirrus.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=grant.likely@linaro.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=lgirdwood@gmail.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=rob@landley.net \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).