From: Tomasz Figa <t.figa@samsung.com>
To: Rahul Sharma <rahul.sharma@samsung.com>,
linux-samsung-soc@vger.kernel.org
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
kgene.kim@samsung.com, tomasz.figa@gmail.com, joshi@samsung.com,
r.sh.open@gmail.com, pankaj.dubey@samsung.com,
Arun Kumar K <arun.kk@samsung.com>
Subject: Re: [PATCH v5 2/3] ARM: dts: add dts files for exynos5260 SoC
Date: Thu, 13 Mar 2014 16:33:57 +0100 [thread overview]
Message-ID: <5321CFE5.2000907@samsung.com> (raw)
In-Reply-To: <1394637394-3960-3-git-send-email-rahul.sharma@samsung.com>
Hi,
On 12.03.2014 16:16, Rahul Sharma wrote:
> The patch adds the dts files for exynos5260.
>
> Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com>
> Signed-off-by: Rahul Sharma <rahul.sharma@samsung.com>
> Signed-off-by: Arun Kumar K <arun.kk@samsung.com>
> Reviewed-by: Tomasz Figa <t.figa@samsung.com>
> ---
> arch/arm/boot/dts/exynos5260-pinctrl.dtsi | 574 +++++++++++++++++++++++++++++
> arch/arm/boot/dts/exynos5260.dtsi | 400 ++++++++++++++++++++
> 2 files changed, 974 insertions(+)
> create mode 100644 arch/arm/boot/dts/exynos5260-pinctrl.dtsi
> create mode 100644 arch/arm/boot/dts/exynos5260.dtsi
>
[snip]
> + mmc_0: mmc0@12140000 {
Node names should specify type of the device, so unit-specific IDs
should be avoided. Please simply use mmc@12140000. The same comment for
remaining MMC nodes below.
Best regards,
Tomasz
next prev parent reply other threads:[~2014-03-13 15:33 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-12 15:16 [PATCH v5 0/3] exynos: arch: add support for exynos5260 SoC Rahul Sharma
2014-03-12 15:16 ` [PATCH v5 1/3] ARM: EXYNOS: initial board " Rahul Sharma
2014-03-12 15:16 ` [PATCH v5 2/3] ARM: dts: add dts files " Rahul Sharma
2014-03-13 0:58 ` Pankaj Dubey
2014-03-13 5:06 ` Rahul Sharma
2014-03-13 18:32 ` Tomasz Figa
2014-03-13 15:33 ` Tomasz Figa [this message]
2014-03-12 15:16 ` [PATCH v5 3/3] ARM: dts: add dts files for xyref5260 board Rahul Sharma
2014-03-13 0:49 ` Pankaj Dubey
2014-03-13 5:01 ` Rahul Sharma
2014-03-13 6:12 ` Rahul Sharma
2014-03-13 18:38 ` Tomasz Figa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5321CFE5.2000907@samsung.com \
--to=t.figa@samsung.com \
--cc=arun.kk@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=joshi@samsung.com \
--cc=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=pankaj.dubey@samsung.com \
--cc=r.sh.open@gmail.com \
--cc=rahul.sharma@samsung.com \
--cc=tomasz.figa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).