From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Elder Subject: Re: [PATCH 0/6] ARM: BCM63XX: add support for BCM63138 SoC Date: Thu, 13 Mar 2014 16:05:49 -0500 Message-ID: <53221DAD.4010708@ieee.org> References: <1394127959-3159-1-git-send-email-f.fainelli@gmail.com> <53193FEE.4060002@ieee.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Kevin Cernekee Cc: Florian Fainelli , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, mporter-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, bcm-xK7y4jjYLqYh9ZMKESR00Q@public.gmane.org, Maxime Bizon , Jonas Gorski , jpeshkin-dY08KVG/lbpWk0Htik3J/w@public.gmane.org List-Id: devicetree@vger.kernel.org On 03/06/2014 10:44 PM, Kevin Cernekee wrote: > On Thu, Mar 6, 2014 at 7:41 PM, Alex Elder wrote: >>> This patchset adds very minimal support for the BCM63138 SoC which is >>> a xDSL SoC using a dual Cortex A9 CPU complex. >> >> >> Why do you use "63xx" for the generic name, when the specific >> part you are defining here is 63138? I would have expected >> "63xxx". > > The product line has a mix of 4-digit and 5-digit part numbers. The > drivers for onchip peripherals all used "bcm63xx": That's too bad. I would suggest that one or the other be used consistently, apparently "63xx" (not 63xxx) would be it. -Alex > $ find drivers/ | grep 63xx > drivers/tty/serial/bcm63xx_uart.c > drivers/pcmcia/bcm63xx_pcmcia.h > drivers/pcmcia/bcm63xx_pcmcia.c > drivers/usb/gadget/bcm63xx_udc.c > drivers/watchdog/max63xx_wdt.c > drivers/watchdog/bcm63xx_wdt.c > drivers/char/hw_random/bcm63xx-rng.c > drivers/mtd/bcm63xxpart.c > drivers/net/phy/bcm63xx.c > drivers/net/ethernet/broadcom/bcm63xx_enet.h > drivers/net/ethernet/broadcom/bcm63xx_enet.c > drivers/spi/spi-bcm63xx.c > drivers/spi/spi-bcm63xx-hsspi.c > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html