From mboxrd@z Thu Jan 1 00:00:00 1970 From: srinivas kandagatla Subject: Re: [PATCH v4 4/6] pinctrl: st: Use ARRAY_SIZE instead of raw value for number of delays Date: Fri, 14 Mar 2014 09:46:49 +0000 Message-ID: <5322D009.3090000@st.com> References: <1394614210-15698-1-git-send-email-maxime.coquelin@st.com> <1394614210-15698-5-git-send-email-maxime.coquelin@st.com> <1394634313.28839.57.camel@joe-AO722> <5322CF87.5000301@st.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <5322CF87.5000301@st.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Maxime Coquelin , Linus Walleij , Joe Perches Cc: Mark Rutland , "devicetree@vger.kernel.org" , Russell King , kernel@stlinux.com, Pawel Moll , Ian Campbell , "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Stuart Menefy , Rob Herring , Rob Landley , Kumar Gala , Giuseppe Cavallaro , Lee Jones , "linux-arm-kernel@lists.infradead.org" List-Id: devicetree@vger.kernel.org On 14/03/14 09:44, Maxime Coquelin wrote: >>> >>> drivers/pinctrl/pinctrl-st.c- unsigned int *input_delays; >>> drivers/pinctrl/pinctrl-st.c- unsigned int *output_delays; >>> >>> It may be better to change these to const unsigned int * >>> and change >>> >>> static unsigned int stih416_delays[] = { >>> >>> to static const >> >> Good point. Patches accepted :-) > > Sorry Joe, I forgot to reply. > > I added this to my todo list. > I will provide the change before end of next week. > Thanks Maxime for taking care of this... --srini > Thanks, > Maxime