RE: [PATCH v3][ 3/9] usb: chipidea: Use standard usb-phy property.

RE: [PATCH v3][ 3/9] usb: chipidea: Use standard usb-phy property.

[Peter Chen]

 
> 
> > According to Power_ePAPR_APPROVED_v1.1.pdf "ethernet-phy" is the node
> > name, it is the same with Sergei's suggestion.
> 
>     Nobody's talking about "ehternet-phy" here.
> 

Hmm, you take "ethernet-phy" as an example, and suggest changing to "usb-phy" at last email.

> > But you have changed the property name at this patch, in fact,
> "fsl,usbphy"
> > is ok for property name, "fsl,usb-phy" may be better, but not worth a
> > patch to change it.
> 
>     No, it's not better and both are not OK because they're still
> Freescale specific while the de-facto standard property "usb-phy" is
> already used by other USB drivers for the same purpose.


Am I missing something, property name should be the same for all platforms?

At Power_ePAPR_APPROVED_v1.1, page 18, the example property name like below:

fsl,channel-fifo-len
ibm,ppc-interrupt-server#s
linux,network-index


Peter

Re: [PATCH v3][ 3/9] usb: chipidea: Use standard usb-phy property.

[Sergei Shtylyov]

Hello.

On 14-03-2014 5:57, Peter Chen wrote:

>>> According to Power_ePAPR_APPROVED_v1.1.pdf "ethernet-phy" is the node
>>> name, it is the same with Sergei's suggestion.

>>      Nobody's talking about "ehternet-phy" here.

> Hmm, you take "ethernet-phy" as an example, and suggest changing to "usb-phy" at last email.

    Then it's a wrong mail. I'm not mixing nodes and properties.

>>> But you have changed the property name at this patch, in fact,
>> "fsl,usbphy"
>>> is ok for property name, "fsl,usb-phy" may be better, but not worth a
>>> patch to change it.

>>      No, it's not better and both are not OK because they're still
>> Freescale specific while the de-facto standard property "usb-phy" is
>> already used by other USB drivers for the same purpose.

> Am I missing something, property name should be the same for all platforms?

    If they're doing the same standard thing, yes.

> Peter

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html