* RE: [PATCH v3][ 3/9] usb: chipidea: Use standard usb-phy property. [not found] ` <5321CF4B.9000308@cogentembedded.com> @ 2014-03-14 1:57 ` Peter Chen [not found] ` <171967ece1414f9ba0e80664777892cb-AZ66ij2kwaYFgBIGFwYtMOO6mTEJWrR4XA4E9RH9d+qIuWR1G4zioA@public.gmane.org> 0 siblings, 1 reply; 2+ messages in thread From: Peter Chen @ 2014-03-14 1:57 UTC (permalink / raw) To: Sergei Shtylyov, Denis Carikli, devicetree@vger.kernel.org Cc: Eric Bénard, Alexander Shiyan, linux-usb@vger.kernel.org, Sascha Hauer, Shawn Guo, Fabio Estevam, linux-arm-kernel@lists.infradead.org > > > According to Power_ePAPR_APPROVED_v1.1.pdf "ethernet-phy" is the node > > name, it is the same with Sergei's suggestion. > > Nobody's talking about "ehternet-phy" here. > Hmm, you take "ethernet-phy" as an example, and suggest changing to "usb-phy" at last email. > > But you have changed the property name at this patch, in fact, > "fsl,usbphy" > > is ok for property name, "fsl,usb-phy" may be better, but not worth a > > patch to change it. > > No, it's not better and both are not OK because they're still > Freescale specific while the de-facto standard property "usb-phy" is > already used by other USB drivers for the same purpose. Am I missing something, property name should be the same for all platforms? At Power_ePAPR_APPROVED_v1.1, page 18, the example property name like below: fsl,channel-fifo-len ibm,ppc-interrupt-server#s linux,network-index Peter ^ permalink raw reply [flat|nested] 2+ messages in thread
[parent not found: <171967ece1414f9ba0e80664777892cb-AZ66ij2kwaYFgBIGFwYtMOO6mTEJWrR4XA4E9RH9d+qIuWR1G4zioA@public.gmane.org>]
* Re: [PATCH v3][ 3/9] usb: chipidea: Use standard usb-phy property. [not found] ` <171967ece1414f9ba0e80664777892cb-AZ66ij2kwaYFgBIGFwYtMOO6mTEJWrR4XA4E9RH9d+qIuWR1G4zioA@public.gmane.org> @ 2014-03-14 11:21 ` Sergei Shtylyov 0 siblings, 0 replies; 2+ messages in thread From: Sergei Shtylyov @ 2014-03-14 11:21 UTC (permalink / raw) To: Peter Chen, Denis Carikli, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Cc: Eric Bénard, Shawn Guo, Sascha Hauer, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Fabio Estevam, Alexander Shiyan Hello. On 14-03-2014 5:57, Peter Chen wrote: >>> According to Power_ePAPR_APPROVED_v1.1.pdf "ethernet-phy" is the node >>> name, it is the same with Sergei's suggestion. >> Nobody's talking about "ehternet-phy" here. > Hmm, you take "ethernet-phy" as an example, and suggest changing to "usb-phy" at last email. Then it's a wrong mail. I'm not mixing nodes and properties. >>> But you have changed the property name at this patch, in fact, >> "fsl,usbphy" >>> is ok for property name, "fsl,usb-phy" may be better, but not worth a >>> patch to change it. >> No, it's not better and both are not OK because they're still >> Freescale specific while the de-facto standard property "usb-phy" is >> already used by other USB drivers for the same purpose. > Am I missing something, property name should be the same for all platforms? If they're doing the same standard thing, yes. > Peter WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-03-14 11:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1394618518-13803-1-git-send-email-denis@eukrea.com>
[not found] ` <1394618518-13803-3-git-send-email-denis@eukrea.com>
[not found] ` <edb50dd0d88541c39fc4b5def88b7f58@BL2PR03MB226.namprd03.prod.outlook.com>
[not found] ` <5321CF4B.9000308@cogentembedded.com>
2014-03-14 1:57 ` [PATCH v3][ 3/9] usb: chipidea: Use standard usb-phy property Peter Chen
[not found] ` <171967ece1414f9ba0e80664777892cb-AZ66ij2kwaYFgBIGFwYtMOO6mTEJWrR4XA4E9RH9d+qIuWR1G4zioA@public.gmane.org>
2014-03-14 11:21 ` Sergei Shtylyov
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).