From: Boris BREZILLON <b.brezillon.dev@gmail.com>
To: Mark Brown <broonie@kernel.org>, Bo Shen <voice.shen@atmel.com>
Cc: nicolas.ferre@atmel.com,
Boris BREZILLON <b.brezillon@overkiz.com>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>, Rob Landley <rob@landley.net>,
devicetree@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org,
Alexandre Belloni <alexandre.belloni@free-electrons.com>
Subject: Re: [PATCH 7/8] ASoC: atmel: document clock properties of the wm8904 driver
Date: Mon, 17 Mar 2014 14:44:00 +0100 [thread overview]
Message-ID: <5326FC20.9020304@gmail.com> (raw)
In-Reply-To: <20140317115518.GD11706@sirena.org.uk>
Hello Mark,
Le 17/03/2014 12:55, Mark Brown a écrit :
> On Mon, Mar 17, 2014 at 05:45:40PM +0800, Bo Shen wrote:
>
>> - compatible: "atmel,asoc-wm8904"
>> - atmel,model: The user-visible name of this sound complex.
>> + - clocks: A list of clocks needed by the wm8904 chip.
>> + - clock-output-names: Driver related clock names. Shall contain "pck0".
> If this is a clock for the CODEC it should be documented as part of the
> binding for the CODEC and connected to the CODEC in the device tree
> rather than being part of a machine driver binding.
Tell me if I'm mistaken, but doing this would implies a lot of changes.
The current wm8904 driver does not handle clk retrieval and configuration,
and I'm afraid that introducing these concepts would break other drivers
(those
connecting to a wm8904 codec).
Do you see a simple alternative to this approach (or is there something
I misunderstood
in your suggestion) ?
How about adding CCF support as proposed in this series and think about
a cleaner
solution for a future release ?
Best Regards,
Boris
next prev parent reply other threads:[~2014-03-17 13:44 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-17 9:45 [PATCH 0/8] ARM: at91: sama5d3: enable sound support Bo Shen
2014-03-17 9:45 ` [PATCH 1/8] ARM: at91: sama5d3: add DMA property for SSC devices Bo Shen
[not found] ` <1395049541-28128-2-git-send-email-voice.shen-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
2014-04-18 20:47 ` Nicolas Ferre
[not found] ` <1395049541-28128-1-git-send-email-voice.shen-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
2014-03-17 9:45 ` [PATCH 2/8] ARM: at91: sama5d3: disable sound by default Bo Shen
[not found] ` <1395049541-28128-3-git-send-email-voice.shen-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
2014-04-18 20:49 ` Nicolas Ferre
2014-04-18 20:35 ` [PATCH 0/8] ARM: at91: sama5d3: enable sound support Nicolas Ferre
2014-04-18 20:38 ` Mark Brown
2014-04-18 22:06 ` Boris BREZILLON
2014-04-18 22:11 ` Nicolas Ferre
2014-03-17 9:45 ` [PATCH 3/8] ARM: at91: sama5d3: correct the sound compatible string Bo Shen
2014-04-18 20:49 ` Nicolas Ferre
2014-03-17 9:45 ` [PATCH 4/8] ARM: at91: sama5d3: add the missing property Bo Shen
2014-04-18 20:50 ` Nicolas Ferre
2014-03-17 9:45 ` [PATCH 5/8] ARM: at91: sama5d3: clock for ssc from rk pin Bo Shen
2014-04-18 20:50 ` Nicolas Ferre
2014-03-17 9:45 ` [PATCH 7/8] ASoC: atmel: document clock properties of the wm8904 driver Bo Shen
2014-03-17 9:54 ` Bo Shen
2014-03-17 10:02 ` Mark Rutland
[not found] ` <20140317100219.GB8070-NuALmloUBlrZROr8t4l/smS4ubULX0JqMm0uRHvK7Nw@public.gmane.org>
2014-03-17 10:18 ` boris brezillon
2014-03-17 10:48 ` Mark Rutland
2014-03-17 11:24 ` Boris BREZILLON
2014-03-17 11:30 ` Mark Rutland
2014-03-17 11:55 ` Mark Brown
2014-03-17 13:44 ` Boris BREZILLON [this message]
2014-03-17 15:28 ` Mark Brown
2014-03-19 5:57 ` Bo Shen
2014-03-19 10:28 ` Mark Brown
[not found] ` <20140319102800.GW11706-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2014-03-20 2:37 ` Bo Shen
2014-03-20 13:47 ` Mark Brown
2014-03-21 2:48 ` Bo Shen
2014-03-17 9:45 ` [PATCH 8/8] ARM: at91/dt: add clock properties to the wm8904 codec node Bo Shen
2014-03-17 9:55 ` Bo Shen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5326FC20.9020304@gmail.com \
--to=b.brezillon.dev@gmail.com \
--cc=alexandre.belloni@free-electrons.com \
--cc=b.brezillon@overkiz.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=nicolas.ferre@atmel.com \
--cc=pawel.moll@arm.com \
--cc=rob@landley.net \
--cc=robh+dt@kernel.org \
--cc=voice.shen@atmel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).