From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sebastian Hesselbarth Subject: Re: [PATCH v4 0/9] Watchdog support for Armada 375/38x SoC Date: Mon, 17 Mar 2014 20:10:58 +0100 Message-ID: <532748C2.9030009@gmail.com> References: <1394907484-26002-1-git-send-email-ezequiel.garcia@free-electrons.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1394907484-26002-1-git-send-email-ezequiel.garcia-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Ezequiel Garcia , linux-watchdog-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org Cc: Jason Cooper , Wim Van Sebroeck , Guenter Roeck , Jason Gunthorpe , Andrew Lunn , Thomas Petazzoni , Gregory Clement , Lior Amsalem , Tawfik Bayouk List-Id: devicetree@vger.kernel.org On 03/15/2014 07:17 PM, Ezequiel Garcia wrote: > Fourth round of the patchset adding support for watchdog on Armada 375 and > Armada 38x SoCs. > > The new Armada 375/385 SoCs have two registers for the watchdog RSTOUT: > > 1. It has a dedicated register (similar to the one in A370/XP) > 2. Also has a bit in a shared RSTOUT register. > > Therefore, in order to support this two-folded RSTOUT, we extend the 'reg' > property in the watchdog devicetree and require a new pair of cells to specify > the shared RSTOUT. > > On the driver side, we need to implement per-SoC stop() and enabled() > functions. Such somewhat complex infrastructure is needed to ensure the driver > performs proper reset of the watchdog timer, by masking and disabling the > RSTOUT before the interrupt is enabled. > > I've pushed a branch so people can test this easily, e.g. ensuring > no regressions on Dove, Kirkwood and A370/XP: Ezequiel, Although, I just saw below that you actually already tested on Dove, you can add my Tested-by: Sebastian Hesselbarth > https://github.com/MISL-EBU-System-SW/mainline-public/tree/wdt_a385_a375_v4 > > Series based on today's mvebu for-next. Will send a rebased version on top of > v3.15-rc1. Tested on A375-DB, A385-DB, A370-RD and Dove Cubox. Sebastian -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html