From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1615C77B7A for ; Thu, 18 May 2023 12:11:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230403AbjERML0 (ORCPT ); Thu, 18 May 2023 08:11:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52912 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231490AbjERMLW (ORCPT ); Thu, 18 May 2023 08:11:22 -0400 Received: from mail-ed1-x536.google.com (mail-ed1-x536.google.com [IPv6:2a00:1450:4864:20::536]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9D69311B for ; Thu, 18 May 2023 05:11:20 -0700 (PDT) Received: by mail-ed1-x536.google.com with SMTP id 4fb4d7f45d1cf-510d8b0169fso2302424a12.1 for ; Thu, 18 May 2023 05:11:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1684411879; x=1687003879; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=eH9Ti4nAq2PZgm6qot+MzQ9siimF1sxRnPpGSpCfOHw=; b=RIBUXrHljuk/rLgpBNTWH/Wt8Vy6eMUK63vu12NMpC4cJ4FN3M5zi2onk/Iw4KYhTm rP6J/j+yirrlO7lqfR9kv8QcE6GGAl+awJPjixU/XDrx15/r2MwInelsa9xHk4rmNgdm FkEzMSUQ1ThUjutqAJMyHrka/ytAY3JXhVk154ofb26rEF6/U7+vVyEKUcDnGTYI8K1J ojFx4daCGQQ0jcEKzcZ6chAV0qZgdIEzptZFV6Lx8YGo3mOF6k5AgQwOyxoXRmDUhjU5 EELFbj+tOxCM0gMyJP42SzyfUSUTaVu1OE8Y2Ol4jr2DKBoti/8WHo0oi95I0BihnWwS HnFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684411879; x=1687003879; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=eH9Ti4nAq2PZgm6qot+MzQ9siimF1sxRnPpGSpCfOHw=; b=b/s8r2FCKC0Xfx9yfDu+TNAqxO9B8AysLciU+eeqePjXp3e5V8MItDWirwF7sQDxhI nhgFHqzHqNhKoV+RyGW0S6MgHhhq4DUMdHaWRfS/xc0truXGSAP5+8sweVmV4oscCp2Z Eevlu7J5yFzmzelWcNbk6xzgkK8cTD9WaHLwpAGZfecYVJo3auB730pX8ZzM2WaDPflK Tzs+jUaJ8KPC7rwxDImnYt1yCsaasGtatckkFBsFAVb1tS3AejDIw6uJhZ898cphGXMm PYG2XXXbYVraULAzNzxpONwrKZuMjaRYkBKHSdHjA7VFeHabqR0n6ORuy0HmQwR/Qsh9 1LGw== X-Gm-Message-State: AC+VfDzo1OUmVYMlbyrjek+8Pv/y2lGbldX9nPUdSf2IOu889bgY0svd ifctjyd/32p1lcza2wDVWeX99Q== X-Google-Smtp-Source: ACHHUZ4c7pZWy3fky9l24pA71DBgsX/CNygp+rtQGgH6TvGPQbJhspz40DPl1raunNLanz3NzAeP1w== X-Received: by 2002:a05:6402:b21:b0:510:d9c8:f180 with SMTP id bo1-20020a0564020b2100b00510d9c8f180mr3745398edb.21.1684411879096; Thu, 18 May 2023 05:11:19 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:a2b:c408:5834:f48e? ([2a02:810d:15c0:828:a2b:c408:5834:f48e]) by smtp.gmail.com with ESMTPSA id j14-20020aa7ca4e000000b00510b5051f95sm508499edt.90.2023.05.18.05.11.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 18 May 2023 05:11:18 -0700 (PDT) Message-ID: <53288f73-8271-9572-14b9-27fa34e2c9fc@linaro.org> Date: Thu, 18 May 2023 14:11:17 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v5 5/5] dt-bindings: clocks: at91sam9x5-sckc: convert to yaml Content-Language: en-US To: Claudiu.Beznea@microchip.com Cc: robh+dt@kernel.org, alexandre.belloni@bootlin.com, linux-kernel@vger.kernel.org, sboyd@kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Nicolas.Ferre@microchip.com, krzysztof.kozlowski+dt@linaro.org, Conor.Dooley@microchip.com, mturquette@baylibre.com, devicetree@vger.kernel.org References: <20230517094119.2894220-1-claudiu.beznea@microchip.com> <20230517094119.2894220-6-claudiu.beznea@microchip.com> <20230517141508.evb6jg5bcpjzhqve@krzk-bin> <79b77cb4-1e18-3c19-15dd-66951541abdf@microchip.com> From: Krzysztof Kozlowski In-Reply-To: <79b77cb4-1e18-3c19-15dd-66951541abdf@microchip.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 18/05/2023 10:31, Claudiu.Beznea@microchip.com wrote: > On 17.05.2023 17:15, Krzysztof Kozlowski wrote: >> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe >> >> On Wed, 17 May 2023 12:41:19 +0300, Claudiu Beznea wrote: >>> Convert Atmel slow clock controller documentation to yaml. >>> >>> Signed-off-by: Claudiu Beznea >>> Reviewed-by: Krzysztof Kozlowski >>> --- >>> .../devicetree/bindings/clock/at91-clock.txt | 30 -------- >>> .../bindings/clock/atmel,at91sam9x5-sckc.yaml | 70 +++++++++++++++++++ >>> 2 files changed, 70 insertions(+), 30 deletions(-) >>> delete mode 100644 Documentation/devicetree/bindings/clock/at91-clock.txt >>> create mode 100644 Documentation/devicetree/bindings/clock/atmel,at91sam9x5-sckc.yaml >>> >> >> Running 'make dtbs_check' with the schema in this patch gives the >> following warnings. Consider if they are expected or the schema is >> incorrect. These may not be new warnings. >> >> Note that it is not yet a requirement to have 0 warnings for dtbs_check. >> This will change in the future. >> >> Full log is available here: https://patchwork.ozlabs.org/patch/1782586 >> >> >> sckc@fffffe50: '#clock-cells' is a required property >> arch/arm/boot/dts/at91sam9n12ek.dtb >> >> sckc@fffffe50: 'clocks' is a required property >> arch/arm/boot/dts/at91sam9n12ek.dtb >> >> sckc@fffffe50: 'slck', 'slow_osc', 'slow_rc_osc' do not match any of the regexes: 'pinctrl-[0-9]+' >> arch/arm/boot/dts/at91sam9n12ek.dtb > > Is it possible that this has been checked on a wrong base? I'm asking this > because: > - patch 3/5 in this series uses proper bindings for slow clock controller > on at91sam9n12.dtsi (which includes #clock-cells and clocks bindings and > removes slck, slow_osc, slow_rc_osc) > - patch 4/5 in this series does s/sckc@/clock-controller@/ in all AT91 > device trees. Yes, it is quite likely. It's up to you to investigate it or ignore if you are sure report is a false positive. > > Moreover, I've re-checked all the individual dtsi files that describes a > slow clock controller and all descriptions has the "#clock-cells", "clocks" > property available and no slck, slow_osc, slow_rc_osc as childs of > sckc@fffffe50. > > If not, could you please let me know your checker command? make dbts_check Best regards, Krzysztof