From: Santosh Shilimkar <santosh.shilimkar@ti.com>
To: Brian Norris <computersforpeace@gmail.com>
Cc: Ivan Khoronzhuk <ivan.khoronzhuk@ti.com>,
dwmw2@infradead.org, galak@codeaurora.org, robh+dt@kernel.org,
pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, rob@landley.net,
linux@arm.linux.org.uk, grygorii.strashko@ti.com,
devicetree@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mtd@lists.infradead.org,
Murali Karicheri <m-karicheri2@ti.com>
Subject: Re: [PATCH 2/3] mtd: davinci-nand: add dts property for NAND_NO_SUBPAGE_WRITE option
Date: Thu, 20 Mar 2014 13:37:42 -0400 [thread overview]
Message-ID: <532B2766.6090506@ti.com> (raw)
In-Reply-To: <20140320172912.GW31517@norris-Latitude-E6410>
On Thursday 20 March 2014 01:29 PM, Brian Norris wrote:
> On Thu, Mar 20, 2014 at 01:12:35PM -0400, Santosh Shilimkar wrote:
>> Boris,
>
> Who's Boris? And why should Boris be taking this patch? It's an MTD
> patch.
>
I got your name completely wrong. Sorry....
>> On Thursday 20 March 2014 01:06 PM, Ivan Khoronzhuk wrote:
>>> From: Murali Karicheri <m-karicheri2@ti.com>
>>>
>>> After testing NAND flash with ubifs for k2hk-emv board were committed
>>> that flash doesn't support subpage writing, so we can fix it by
>>> adding a property to disable subpage write.
>
> What flash? We try to autodetect NAND as much as possible. Perhaps we
> should be adding infrastructure support instead of hacking it with a DT
> property.
>
We can't auto detect it and thats why the DT approach was taken. We
will double check that.
>>> Signed-off-by: Murali Karicheri <m-karicheri2@ti.com>
>>> Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@ti.com>
>>> ---
>> Can you please pick this up for 3.15 fixes ? Ofcourse assuming DT folks
>> are ok with the patch.
>>
>> I can then take patch 1/3 and 3/3 in my 3.15 fixes queue.
>>
>>> Documentation/devicetree/bindings/mtd/davinci-nand.txt | 2 ++
>>> drivers/mtd/nand/davinci_nand.c | 3 +++
>>> 2 files changed, 5 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/mtd/davinci-nand.txt b/Documentation/devicetree/bindings/mtd/davinci-nand.txt
>>> index cfb18ab..50af930 100644
>>> --- a/Documentation/devicetree/bindings/mtd/davinci-nand.txt
>>> +++ b/Documentation/devicetree/bindings/mtd/davinci-nand.txt
>>> @@ -53,6 +53,8 @@ Recommended properties :
>>> identifier is saved in OOB area. If not present
>>> false.
>>>
>>> +- ti,davinci-nosubpage-write: disable subpage write for the device
>
> If we really need the DT property, I'd prefer a generic
> "nand-numer-of-partial-programs" or something like that, and if it's
> equal to 1, then the flash doesn't support partial page programming.
>
OK. It can be updated as you suggested.
Thanks for quick response and sorry for the rename
Regards,
Santosh
next prev parent reply other threads:[~2014-03-20 17:37 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-20 17:06 [PATCH 0/3] Fix NAND propeties for k2hk-evm Ivan Khoronzhuk
2014-03-20 17:06 ` [PATCH 1/3] ARM: dts: k2hk-evm: set ubifs partition size for 512M NAND Ivan Khoronzhuk
2014-03-20 17:06 ` [PATCH 2/3] mtd: davinci-nand: add dts property for NAND_NO_SUBPAGE_WRITE option Ivan Khoronzhuk
2014-03-20 17:12 ` Santosh Shilimkar
2014-03-20 17:29 ` Brian Norris
2014-03-20 17:37 ` Santosh Shilimkar [this message]
2014-03-20 17:44 ` Warner Losh
2014-03-20 18:02 ` Santosh Shilimkar
2014-03-20 18:09 ` Warner Losh
2014-03-20 18:54 ` Brian Norris
2014-03-20 19:11 ` Santosh Shilimkar
2014-03-20 19:26 ` Ivan Khoronzhuk
2014-03-20 19:28 ` Santosh Shilimkar
2014-03-20 18:42 ` Brian Norris
2014-03-20 17:06 ` [PATCH 3/3] ARM: dts: k2hk-evm: disable subpage write for davinci nand device Ivan Khoronzhuk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=532B2766.6090506@ti.com \
--to=santosh.shilimkar@ti.com \
--cc=computersforpeace@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dwmw2@infradead.org \
--cc=galak@codeaurora.org \
--cc=grygorii.strashko@ti.com \
--cc=ijc+devicetree@hellion.org.uk \
--cc=ivan.khoronzhuk@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux@arm.linux.org.uk \
--cc=m-karicheri2@ti.com \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=rob@landley.net \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).