From mboxrd@z Thu Jan 1 00:00:00 1970 From: Huang Shijie Subject: Re: [PATCHv2 1/1] mtd: gpmi: make blockmark swapping optional Date: Fri, 28 Mar 2014 18:09:10 +0800 Message-ID: <53354A46.9040807@freescale.com> References: <1395399017-19005-1-git-send-email-LW@KARO-electronics.de> <20140324095902.GB11377@localhost> <20140326095156.3e5585b8@ipc1.ka-ro> <5332AEE7.2040402@freescale.com> <20140326125502.0e8d0657@ipc1.ka-ro> <20140327095956.GA29623@localhost> <20140327132109.06258526@ipc1.ka-ro> <5334D9F7.2030001@freescale.com> <20140328091646.1ce03f90@ipc1.ka-ro> <53353524.9020605@freescale.com> <20140328090023.GB17250@pengutronix.de> <53354057.6030004@freescale.com> <20140328103147.3fdadfd7@ipc1.ka-ro> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <20140328103147.3fdadfd7@ipc1.ka-ro> Sender: linux-doc-owner@vger.kernel.org To: =?UTF-8?B?TG90aGFyIFdhw59tYW5u?= Cc: Sascha Hauer , Fabio Estevam , Mark Rutland , Brian Norris , Russell King , Pawel Moll , Arnd Bergmann , Ian Campbell , Artem Bityutskiy , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Rob Herring , linux-mtd@lists.infradead.org, Shawn Guo , Rob Landley , Kumar Gala , Shawn Guo , David Woodhouse , Sascha Hauer , linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org =E4=BA=8E 2014=E5=B9=B403=E6=9C=8828=E6=97=A5 17:31, Lothar Wa=C3=9Fman= n =E5=86=99=E9=81=93: > Hi, > > Huang Shijie wrote: >> =E4=BA=8E 2014=E5=B9=B403=E6=9C=8828=E6=97=A5 17:00, Sascha Hauer =E5= =86=99=E9=81=93: >>> - disables swapping of BB marks in the FCB the ROM won't swap bytes= =2E >> We can not disable the swapping in the FCB in the imx28. >> The DISBBM bit in the FCB does _NOT_ exit in the imx28's FCB. >> > The Linux kernel does not have any business with the FCB, so it is > completely irrelevant for Linux whether byte swapping can be disabled > in the FCB or not. > But the gpmi is relevant to the ROM. the gpmi driver should keep consistency with the ROM. I do not object you add the swapping optional the gpmi driver(since it'= s=20 ok for imx50/imx6q/imx6sx), i just object that you enable this feature for imx28. thanks Huang Shijie