From mboxrd@z Thu Jan  1 00:00:00 1970
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Subject: Re: [PATCH 6/9] ARM: shmobile: r8a7790: add audio dmac node
Date: Tue, 08 Apr 2014 00:39:24 +0400
Message-ID: <53430CFC.7000107@cogentembedded.com>
References: <1396901229-29117-1-git-send-email-ben.dooks@codethink.co.uk> <1396901229-29117-7-git-send-email-ben.dooks@codethink.co.uk>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Return-path: <linux-sh-owner@vger.kernel.org>
In-Reply-To: <1396901229-29117-7-git-send-email-ben.dooks@codethink.co.uk>
Sender: linux-sh-owner@vger.kernel.org
To: Ben Dooks <ben.dooks@codethink.co.uk>, linux-kernel@lists.codethink.co.uk, dmaengine@vger.kernel.org
Cc: vinod.koul@intel.com, dan.j.williams@intel.com, linux-sh@vger.kernel.org, magnus.damm@opensource.se, horms@verge.net.au, g.liakhovetski@gmx.d, kuninori.morimoto.gx@renesas.com, devicetree@vger.kernel.org
List-Id: devicetree@vger.kernel.org

Hello.

On 04/08/2014 12:07 AM, Ben Dooks wrote:

> Add initial audio dmac node and resources.

> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
> ---
>   arch/arm/boot/dts/r8a7790.dtsi | 68 ++++++++++++++++++++++++++++++++++++++++++
>   1 file changed, 68 insertions(+)
>
> diff --git a/arch/arm/boot/dts/r8a7790.dtsi b/arch/arm/boot/dts/r8a7790.dtsi
> index 2c8cbbd..6032783 100644
> --- a/arch/arm/boot/dts/r8a7790.dtsi
> +++ b/arch/arm/boot/dts/r8a7790.dtsi
> @@ -176,6 +176,74 @@
>   		};
>   	};
>
> +	dma1: dma-mux@1 {
> +		compatible = "renesas,shdma-mux";
> +		#dma-cells = <1>;
> +		dma-channels = <20>;
> +		dma-requests = <256>;
> +		#address-cells = <2>;
> +		#size-cells = <2>;
> +		ranges;
> +
> +		audiodma0: dmac@ec700000 {

    According to the ePARR standard [1], the node name should be 
"dma-controller", not just "dmac".

> +			compatible = "renesas,dma-r8a7790", "renesas,dma-arm";
> +			clocks = <&mstp5_clks R8A7790_CLK_AUDIO_DMAC0>;
> +			dma-channels = <13>;
> +			status = "disabled";
> +			reg = <0 0xec700020 0 0xffc0>;
> +			interrupt-parent = <&gic>;

    Shouldn't it be just inherited from the top level node?

[1] http://www.power.org/resources/downloads/Power_ePAPR_APPROVED_v1.0.pdf

WBR, Sergei