From: Timur Tabi <timur@codeaurora.org>
To: "Ivan T. Ivanov" <iivanov@mm-sol.com>
Cc: Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Russell King <linux@arm.linux.org.uk>,
devicetree@vger.kernel.org, lkml <linux-kernel@vger.kernel.org>,
linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH 2/2] ARM: dts: MSM8974: Add pinctrl node
Date: Tue, 08 Apr 2014 07:33:11 -0500 [thread overview]
Message-ID: <5343EC87.700@codeaurora.org> (raw)
In-Reply-To: <1396959284.28420.45.camel@iivanov-dev>
Ivan T. Ivanov wrote:
>> >I'm confused by this. Isn't this information already defined in the
>> >pinctrl-msm8x74.c driver?
>> >
>> >static const char * const blsp_spi8_groups[] = {
>> > "gpio45", "gpio46", "gpio47", "gpio48"
>> >};
> I am not sure that I understand the question. This is one of
> possible ways to describe relationship between pins and functions.
> As they are described is visible what is their real purpose.
Ok, let me rephrase.
The 8x74 pinctrl driver already contains this information. It already
defines a "blsp_spi8" group consisting of GPIOs 45, 46, 47, and 48.
This patch adds that same exact information into the device tree. Why
are we duplicating that information? Why add it to the device tree when
it's already in the driver (and already working).
Also, I don't see any code anywhere that uses these new device tree nodes.
--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the
Code Aurora Forum, hosted by The Linux Foundation.
next prev parent reply other threads:[~2014-04-08 12:33 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1391700529-11816-1-git-send-email-iivanov@mm-sol.com>
2014-02-06 15:28 ` [PATCH 2/2] ARM: dts: MSM8974: Add pinctrl node Ivan T. Ivanov
2014-02-10 18:55 ` Bjorn Andersson
2014-02-11 20:28 ` Kumar Gala
[not found] ` <1391700529-11816-2-git-send-email-iivanov-NEYub+7Iv8PQT0dZR+AlfA@public.gmane.org>
2014-02-24 9:57 ` Linus Walleij
2014-02-25 15:50 ` Kumar Gala
2014-04-07 23:53 ` Timur Tabi
2014-04-08 12:14 ` Ivan T. Ivanov
2014-04-08 12:33 ` Timur Tabi [this message]
2014-04-08 13:46 ` Ivan T. Ivanov
2014-04-08 14:18 ` Timur Tabi
2014-04-08 15:26 ` Timur Tabi
2014-04-08 18:39 ` Bjorn Andersson
2014-04-10 16:22 ` Linus Walleij
2014-04-08 12:12 ` Timur Tabi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5343EC87.700@codeaurora.org \
--to=timur@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=iivanov@mm-sol.com \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).