From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sylwester Nawrocki Subject: Re: [PATCH] phy: exynos5-usbdrd: Add facility to toggle vbus gpio on/off Date: Wed, 09 Apr 2014 15:08:56 +0200 Message-ID: <53454668.8090300@samsung.com> References: <1397044485-26483-1-git-send-email-gautam.vivek@samsung.com> <534538F6.2010009@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-reply-to: Sender: linux-kernel-owner@vger.kernel.org To: Vivek Gautam Cc: kishon , Linux USB Mailing List , "linux-samsung-soc@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , Greg KH , Felipe Balbi , Kukjin Kim , Tomasz Figa , Kamil Debski , Jingoo Han List-Id: devicetree@vger.kernel.org On 09/04/14 14:24, Vivek Gautam wrote: > On Wed, Apr 9, 2014 at 5:41 PM, Sylwester Nawrocki > wrote: >> > On 09/04/14 13:54, Vivek Gautam wrote: >>> >> Adding support to enable/disable VBUS hooked to a gpio >>> >> to enable vbus supply on the port. >> > >> > Does the GPIO control a fixed voltage regulator ? If so, shouldn't >> > it be modelled by the regulator API instead ? > > No, this GPIO controls a 'current limiting power distribution switch', > which gives the output vbus to usb controller. > Should i model this as a fixed regulator ? OK, it's just a power switch then. I suspect using the regulator API would be more universal, as such a GPIO is somewhat a board design detail. I'm not going to object to your patch, just might be better to use the gpiod API instead. -- Regards, Sylwester