From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gregory CLEMENT Subject: Re: [PATCH 2/4] dt-bindings: add mtk-timer bindings Date: Wed, 09 Apr 2014 20:56:34 +0000 Message-ID: <5345B402.9070904@free-electrons.com> References: <1397072736-10793-1-git-send-email-matthias.bgg@gmail.com> <1397072736-10793-3-git-send-email-matthias.bgg@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1397072736-10793-3-git-send-email-matthias.bgg@gmail.com> Sender: linux-doc-owner@vger.kernel.org To: Matthias Brugger , linux-kernel@vger.kernel.org Cc: mark.rutland@arm.com, andrew@lunn.ch, linux-doc@vger.kernel.org, thierry.reding@gmail.com, heiko.stuebner@bq.com, linux@arm.linux.org.uk, daniel.lezcano@linaro.org, florian.vaussard@epfl.ch, sebastian.hesselbarth@gmail.com, devicetree@vger.kernel.org, jason@lakedaemon.net, pawel.moll@arm.com, ijc+devicetree@hellion.org.uk, robh+dt@kernel.org, tglx@linutronix.de, linux-arm-kernel@lists.infradead.org, rdunlap@infradead.org, silvio.fricke@gmail.com, galak@codeaurora.org, olof@lixom.net, jic23@kernel.org List-Id: devicetree@vger.kernel.org Hi Matthias, On 09/04/2014 19:45, Matthias Brugger wrote: > Add binding documentation for the General Porpose Timer driver of > the Mediatek SoCs. > > Signed-off-by: Matthias Brugger > --- > .../bindings/timer/mediatek,mtk-timer.txt | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) > create mode 100644 Documentation/devicetree/bindings/timer/mediatek,mtk-timer.txt > > diff --git a/Documentation/devicetree/bindings/timer/mediatek,mtk-timer.txt b/Documentation/devicetree/bindings/timer/mediatek,mtk-timer.txt > new file mode 100644 > index 0000000..db3c836 > --- /dev/null > +++ b/Documentation/devicetree/bindings/timer/mediatek,mtk-timer.txt > @@ -0,0 +1,19 @@ > +Mediatek MT6598, MT6577 and MT6572 Timers > +--------------------------------------- > + > +Required properties: > +- compatible: Should be "mediatek,mtk6589-timer" > +- reg: Should contain location and length for timers register. > +- clock-names : Must include the following entries: > + "sysclk" (13 MHz system clock), > + "rtcclk" (32 KHz RTC clock). It would be better to make the clocks mandatory and not their name Thanks, Gregory > + > +Examples: > + > + timer { > + compatible = "mediatek,mtk6589-timer"; > + reg = <0x10008000 0x80>; > + interrupts = ; > + clocks = <&system_clk>, <&rtc-clk>; > + clock-names = "sysclk", "rtcclk"; > + }; > -- Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com