From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [PATCH] ARM: shmobile: r8a7790: link PCI USb devices to USB PHY Date: Thu, 10 Apr 2014 22:46:47 +0400 Message-ID: <5346E717.4040507@cogentembedded.com> References: <201404092318.26231.sergei.shtylyov@cogentembedded.com> <534674B5.6080706@cogentembedded.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <534674B5.6080706@cogentembedded.com> Sender: linux-sh-owner@vger.kernel.org To: Magnus Damm Cc: "Simon Horman [Horms]" , SH-Linux , "devicetree@vger.kernel.org" , robh+dt@kernel.org, Pawel Moll , Mark Rutland , ijc+devicetree@hellion.org.uk, Kumar Gala , Russell King - ARM Linux , "linux-arm-kernel@lists.infradead.org" List-Id: devicetree@vger.kernel.org On 04/10/2014 02:38 PM, Sergei Shtylyov wrote: >> Thanks for this patch, good to see that the relationship between the >> USB Host and the PHY is described via DT. >> This patch seems to cover USB0 and USB2 that both require special >> control in the PHY. How about USB1? Can you explain about the reason >> why you omit that? > Because the driver does nothing for USB1 anyway. Looks like I should have tested that last minute change: kernel oopses due to NULL pointer dereference somewhere in phy_get() once it gets called for EHCI on the channel #1. At least doesn't seem to be my mistake... WBR, Sergei