From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chanwoo Choi Subject: Re: [PATCHv2 5/8] ARM: EXYNOS: Support secondary CPU boot of Exynos3250 Date: Thu, 17 Apr 2014 19:15:09 +0900 Message-ID: <534FA9AD.7000406@samsung.com> References: <1397527192-21988-1-git-send-email-cw00.choi@samsung.com> <1397527192-21988-6-git-send-email-cw00.choi@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Return-path: In-reply-to: Sender: linux-kernel-owner@vger.kernel.org To: Tushar Behera Cc: lkml , Russell King - ARM Linux , Ben Dooks , Kukjin Kim , Tomasz Figa , Thomas Abraham , Kyungmin Park , sw0312.kim@samsung.com, hyunhee.kim@samsung.com, yj44.cho@samsung.com, =?UTF-8?B?67CV7LCs7Zi4?= , Arnd Bergmann , Olof Johansson , marc.zyngier@arm.com, linux-samsung-soc , "linux-arm-kernel@lists.infradead.org" , devicetree List-Id: devicetree@vger.kernel.org Hi Tushar, On 04/15/2014 02:09 PM, Tushar Behera wrote: > On 15 April 2014 07:29, Chanwoo Choi wrote: >> This patch fix the offset of CPU boot address and don't operate smc call >> of SMC_CMD_CPU1BOOT command for Exynos3250. >> >> Signed-off-by: Chanwoo Choi >> Acked-by: Kyungmin Park >> --- >> arch/arm/mach-exynos/firmware.c | 7 +++++-- >> 1 file changed, 5 insertions(+), 2 deletions(-) >> >> diff --git a/arch/arm/mach-exynos/firmware.c b/arch/arm/mach-exynos/firmware.c >> index aa01c42..6205d4f 100644 >> --- a/arch/arm/mach-exynos/firmware.c >> +++ b/arch/arm/mach-exynos/firmware.c >> @@ -30,13 +30,16 @@ static int exynos_do_idle(void) >> >> static int exynos_cpu_boot(int cpu) >> { >> + if (soc_is_exynos3250()) { >> + return 0; >> /* >> * The second parameter of SMC_CMD_CPU1BOOT command means CPU id. >> * But, Exynos4212 has only one secondary CPU so second parameter >> * isn't used for informing secure firmware about CPU id. >> */ >> - if (soc_is_exynos4212()) >> + } else if (soc_is_exynos4212()) { >> cpu = 0; >> + } >> > > As you already return in case of Exynos3250, you need not change this. > First commit hunk without the opening brace should be sufficient. OK, I'll remove brace. Best Regards, Chanwoo Choi