From: Sylwester Nawrocki <s.nawrocki@samsung.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: linux-media@vger.kernel.org,
Hans Verkuil <hans.verkuil@cisco.com>,
Lars-Peter Clausen <lars@metafoo.de>,
devicetree@vger.kernel.org
Subject: Re: [PATCH v2 46/48] adv7604: Add DT support
Date: Thu, 17 Apr 2014 15:41:23 +0200 [thread overview]
Message-ID: <534FDA03.20901@samsung.com> (raw)
In-Reply-To: <2010144.jYKNNgF1x7@avalon>
On 17/04/14 15:08, Laurent Pinchart wrote:
>>>> static struct i2c_driver adv7604_driver = {
>>>> > > >
>>>> > > > .driver = {
>>>> > > >
>>>> > > > .owner = THIS_MODULE,
>>>> > > > .name = "adv7604",
>>>> > > >
>>>> > > > + .of_match_table = of_match_ptr(adv7604_of_id),
>>> > >
>>> > > of_match_ptr() isn't necessary here.
>> >
>> > Thanks, will fix in v3.
>
> On second thought, as the driver has non-DT users, keeping of_match_ptr() and
> marking the table as __maybe_unused will optimize the table out if neither
> CONFIG_OF nor CONFIG_MODULE is set. I'd thus prefer keeping of_match_ptr().
Yes, itsounds like a good idea to me. This way we avoid unpleasant #ifdefs
and do not increase size of the module for non-dt users.
--
Regards,
Sylwester
prev parent reply other threads:[~2014-04-17 13:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1394493359-14115-1-git-send-email-laurent.pinchart@ideasonboard.com>
2014-03-10 23:15 ` [PATCH v2 46/48] adv7604: Add DT support Laurent Pinchart
2014-04-17 10:59 ` Sylwester Nawrocki
2014-04-17 12:36 ` Laurent Pinchart
2014-04-17 13:08 ` Laurent Pinchart
2014-04-17 13:41 ` Sylwester Nawrocki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=534FDA03.20901@samsung.com \
--to=s.nawrocki@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=hans.verkuil@cisco.com \
--cc=lars@metafoo.de \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).