From: Sylwester Nawrocki <s.nawrocki@samsung.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: linux-media@vger.kernel.org,
Hans Verkuil <hans.verkuil@cisco.com>,
Lars-Peter Clausen <lars@metafoo.de>,
devicetree@vger.kernel.org
Subject: Re: [PATCH v4 45/49] adv7604: Add DT support
Date: Thu, 17 Apr 2014 16:52:08 +0200 [thread overview]
Message-ID: <534FEA98.5000901@samsung.com> (raw)
In-Reply-To: <534FE7A1.8060800@samsung.com>
On 17/04/14 16:39, Sylwester Nawrocki wrote:
> On 17/04/14 16:13, Laurent Pinchart wrote:
>> > Parse the device tree node to populate platform data. Only the ADV7611
>> > is currently support with DT.
>> >
>> > Cc: devicetree@vger.kernel.org
>> > Cc: Sylwester Nawrocki <s.nawrocki@samsung.com>
>> > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>> > Acked-by: Hans Verkuil <hans.verkuil@cisco.com>
> The patch looks good to me.
>
> Acked-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
>
> Just one comment below...
>> > ---
[...]
>> > +static struct of_device_id adv7604_of_id[] = {
>
> Not adding __maybe_unused attribute to this one ?
I missed it's added in the last patch in this series, please ignore
this comment.
--
Regards,
Sylwester
next prev parent reply other threads:[~2014-04-17 14:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1397744000-23967-1-git-send-email-laurent.pinchart@ideasonboard.com>
2014-04-17 14:13 ` [PATCH v4 45/49] adv7604: Add DT support Laurent Pinchart
2014-04-17 14:39 ` Sylwester Nawrocki
2014-04-17 14:43 ` Laurent Pinchart
2014-04-17 14:52 ` Sylwester Nawrocki [this message]
2014-04-17 14:13 ` [PATCH v4 47/49] adv7604: Add endpoint properties to DT bindings Laurent Pinchart
2014-04-17 14:44 ` Sylwester Nawrocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=534FEA98.5000901@samsung.com \
--to=s.nawrocki@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=hans.verkuil@cisco.com \
--cc=lars@metafoo.de \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox