From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gregory CLEMENT Subject: Re: [PATCH 5/8] ARM: mvebu: Add Device Tree description of xHCI hosts on Armada 38x Date: Fri, 18 Apr 2014 13:45:08 +0200 Message-ID: <53511044.9070601@free-electrons.com> References: <1397816563-9000-1-git-send-email-gregory.clement@free-electrons.com> <1397816563-9000-6-git-send-email-gregory.clement@free-electrons.com> <53510B28.1070709@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <53510B28.1070709-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Sebastian Hesselbarth Cc: Mathias Nyman , Greg Kroah-Hartman , linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Jason Cooper , Andrew Lunn , Thomas Petazzoni , Ezequiel Garcia , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Lior Amsalem , Tawfik Bayouk , Nadav Haklai , Grant Likely , Rob Herring , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org Hi Sebastian, On 18/04/2014 13:23, Sebastian Hesselbarth wrote: > On 04/18/2014 12:22 PM, Gregory CLEMENT wrote: >> The Marvell Armada 38x SoCs contain two xHCI host. This commit adds >> the Device Tree description of those interfaces at the SoC level, and >> also enables the two USB3 ports on the Armada 385 DB platform and one >> USB3 port on the Armada 385 RD platforms. >> >> Signed-off-by: Gregory CLEMENT >> --- >> arch/arm/boot/dts/armada-385-db.dts | 8 ++++++++ >> arch/arm/boot/dts/armada-385-rd.dts | 4 ++++ >> arch/arm/boot/dts/armada-38x.dtsi | 17 +++++++++++++++++ >> 3 files changed, 29 insertions(+) > [...] >> diff --git a/arch/arm/boot/dts/armada-38x.dtsi b/arch/arm/boot/dts/armada-38x.dtsi >> index a064f59da02d..4f117e66aa1a 100644 >> --- a/arch/arm/boot/dts/armada-38x.dtsi >> +++ b/arch/arm/boot/dts/armada-38x.dtsi >> @@ -355,6 +355,23 @@ >> clocks = <&coredivclk 0>; >> status = "disabled"; >> }; >> + >> + usb3@f0000 { >> + compatible = "marvell,xhci-armada-380"; >> + reg = <0xf0000 0x3fff>,<0xf4000 0x3fff>; >> + interrupts = ; >> + clocks = <&gateclk 9>; > > Using generic PHY framework will allow you to reference the PHY nodes > with "usb-phy" here. > > BTW, you added a "marvell,armada-380-usb-utmi" in the patch for PHY init > but I can see no corresponding node added. Yes a commit was lost during one of my rebase! Thanks to git reflog, I found it. Thanks, Gregory > > Sebastian > >> + status = "disabled"; >> + }; >> + >> + usb3@f8000 { >> + compatible = "marvell,xhci-armada-380"; >> + reg = <0xf8000 0x3fff>,<0xfc000 0x3fff>; >> + interrupts = ; >> + clocks = <&gateclk 10>; >> + status = "disabled"; >> + }; >> + >> }; >> }; >> >> > -- Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html