From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Michal Simek <michal.simek@amd.com>,
Conor Dooley <conor@kernel.org>,
Piyush Mehta <piyush.mehta@amd.com>
Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
conor+dt@kernel.org, p.zabel@pengutronix.de,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
git@amd.com
Subject: Re: [PATCH 1/2] dt-bindings: reset: Updated binding for Versal-NET reset driver
Date: Wed, 19 Jul 2023 08:36:45 +0200 [thread overview]
Message-ID: <5353872c-56a3-98f9-7f22-ec1f6c2ccdc8@linaro.org> (raw)
In-Reply-To: <3f76ff03-963d-fff8-b512-abce447da7d0@amd.com>
On 19/07/2023 08:23, Michal Simek wrote:
>> Yes. If you want to store some constants (register values, firmware
>> magic numbers) and use in DTS, this is the way to go. Most (or all) of
>> examples above are for register values.
>
> I did small grepping over Linux (reset only) and I found that all of these files
> are not used by any driver/code. They are included in binding document or dt files.
> Based on your description above they all are candidates for removing from
> include/dt-bindings/reset/.
> On the other hand that files could be used in different projects out of Linux
> where that values could be used by a driver/code.
Yes, therefore this should be case-by-case decision.
>
> What to do with it? Should we remove it, deprecate it or just keep it and not to
> add new one? I just want to know how to properly handle it.
They cannot be removed. They could be copied to DTS and deprecated in
the bindings. But it is not that important that we clean it up... or it
is rather to the platform maintainer. I did it some time ago for Samsung
and recently TI is doing for serdes mux bindings.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-07-19 6:37 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-17 11:23 [PATCH 0/2] reset: reset-zynqmp: add support for Versal NET platform Piyush Mehta
2023-07-17 11:23 ` [PATCH 1/2] dt-bindings: reset: Updated binding for Versal-NET reset driver Piyush Mehta
2023-07-17 18:40 ` Conor Dooley
2023-07-17 20:47 ` Krzysztof Kozlowski
2023-07-18 7:10 ` Michal Simek
2023-07-18 7:39 ` Krzysztof Kozlowski
2023-07-18 13:11 ` Michal Simek
2023-07-18 13:20 ` Krzysztof Kozlowski
2023-07-18 13:21 ` Krzysztof Kozlowski
2023-07-18 13:59 ` Michal Simek
2023-07-18 14:01 ` Michal Simek
2023-07-18 14:04 ` Krzysztof Kozlowski
2023-07-18 14:30 ` Michal Simek
2023-07-18 18:01 ` Krzysztof Kozlowski
2023-07-19 6:23 ` Michal Simek
2023-07-19 6:36 ` Krzysztof Kozlowski [this message]
2023-07-17 11:23 ` [PATCH 2/2] reset: reset-zynqmp: add support for Versal NET platform Piyush Mehta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5353872c-56a3-98f9-7f22-ec1f6c2ccdc8@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=conor+dt@kernel.org \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=git@amd.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@amd.com \
--cc=p.zabel@pengutronix.de \
--cc=piyush.mehta@amd.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).