From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3C66C7EE23 for ; Tue, 16 May 2023 01:23:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229543AbjEPBXt (ORCPT ); Mon, 15 May 2023 21:23:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48420 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229595AbjEPBXs (ORCPT ); Mon, 15 May 2023 21:23:48 -0400 Received: from mail-lj1-x22d.google.com (mail-lj1-x22d.google.com [IPv6:2a00:1450:4864:20::22d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6D86A6581 for ; Mon, 15 May 2023 18:23:40 -0700 (PDT) Received: by mail-lj1-x22d.google.com with SMTP id 38308e7fff4ca-2ac7f53ae44so143940201fa.2 for ; Mon, 15 May 2023 18:23:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1684200218; x=1686792218; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=hFsdzrNUCB91yNriDm61THdPDwlSojJxD49b8QFiUmM=; b=hZfzw1jWLGlfj8aOiW0+povajyBUAE80+Nt0QYyn45dJJMfs0gqgxKSxoRDOXWG4bQ 1ifplYkaZPR7ivNrnAMm8prJAz7Wzyi2ohvFRNSF07Nw5vVaRZvt8tB0xCvq+k8FPBQX T3HSyMWnaUSMfXUUK9ueruIMYHm2mpQJUsdjEGxrNILNqrPo9M75WwnwisBl7GlNX31q xytqmiy2rMbiTklYK2HKt2rXrBdKcr1Fk0hpNjeL8PuLYfmgEiLqGHNnkhoNBsXACELy pTFM+v3bKjao9OWeNtJtAR5Nrc8hJyX6wAnWWpSSjX46AzZa4GxgMVJpOqdjxliuoX8p CyRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684200218; x=1686792218; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=hFsdzrNUCB91yNriDm61THdPDwlSojJxD49b8QFiUmM=; b=irX2FD794GOJ1dlgTK7TzKMAwCvNzoGzuxjBn58kDhIujxsLKeS4yujdNBUSdnw3A/ h1kce7QyJSXmDieo5kVKh3qR2d7HBrdr515u9w8rrOt4BhSvzGvUyV+D/D6NlRy4KQVF OWWTjypsXkoCG7rtrpNW3Rc5KlrmlpirZ5wmK5gLHpG+mZdiCFTSmFcA4NSOPNoRO2BP OHI0CGy3MNeiHhfOcJZwc4fLTq3pZRwiSGLkQMP/rUIpso7WBiuvqGEk1TewhnsWrUB8 ehzIxJpYOIe1Wi7f2cNhcj4hI0ZWxh+u7P4JLVd898XvmW5JOHmJYIy/O2fu4GnRs9Fe zBYQ== X-Gm-Message-State: AC+VfDxv4o0h+VJsTW6mHF8nJvIIXTeVf+aQMhsH53SPOZ5lFTMxTEHg 7de/rI0xKT2JpilPaJcxdYQvfQ== X-Google-Smtp-Source: ACHHUZ4v7ANIpHd1PgWjbMlH9q/KP2hjU5YgkpFLPMRPmOhdHzM9lfAf1/Fv4mxIbS3a7C99nWveAw== X-Received: by 2002:ac2:532a:0:b0:4f3:84dd:a4e with SMTP id f10-20020ac2532a000000b004f384dd0a4emr992846lfh.37.1684200218653; Mon, 15 May 2023 18:23:38 -0700 (PDT) Received: from [192.168.1.101] (abxi58.neoplus.adsl.tpnet.pl. [83.9.2.58]) by smtp.gmail.com with ESMTPSA id y27-20020ac2447b000000b004db3eff4b12sm2651977lfl.171.2023.05.15.18.23.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 15 May 2023 18:23:38 -0700 (PDT) Message-ID: <5353e51c-46c5-5178-fa1b-65fb71072e7f@linaro.org> Date: Tue, 16 May 2023 03:23:36 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v4 5/5] arm64: dts: qcom: qrb4210-rb2: Enable EUD debug peripheral Content-Language: en-US To: Bhupesh Sharma , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-usb@vger.kernel.org Cc: agross@kernel.org, andersson@kernel.org, linux-kernel@vger.kernel.org, bhupesh.linux@gmail.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, krzysztof.kozlowski@linaro.org References: <20230505064039.1630025-1-bhupesh.sharma@linaro.org> <20230505064039.1630025-6-bhupesh.sharma@linaro.org> From: Konrad Dybcio In-Reply-To: <20230505064039.1630025-6-bhupesh.sharma@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 5.05.2023 08:40, Bhupesh Sharma wrote: > Since the USB-C type port on the Qualcomm QRB4210-RB2 board > can be set primarily in a 'device' configuration (with the default > DIP switch settings), it makes sense to enable the EUD debug > peripheral on the board by default by setting the USB 'dr_mode' property > as 'otg'. > > Now, the EUD debug peripheral can be enabled by executing: > $ echo 1 > /sys/bus/platform/drivers/qcom_eud/1610000.eud/enable > > Signed-off-by: Bhupesh Sharma > --- Reviewed-by: Konrad Dybcio Konrad > arch/arm64/boot/dts/qcom/qrb4210-rb2.dts | 27 +++++++++++++++++++++++- > 1 file changed, 26 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts b/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts > index 1a0776a0cfd0..0ce72f1ebc10 100644 > --- a/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts > +++ b/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts > @@ -30,6 +30,10 @@ vph_pwr: vph-pwr-regulator { > }; > }; > > +&eud { > + status = "okay"; > +}; > + > &qupv3_id_0 { > status = "okay"; > }; > @@ -253,7 +257,28 @@ &usb { > > &usb_dwc3 { > maximum-speed = "super-speed"; > - dr_mode = "peripheral"; > + > + /* > + * There is only one USB DWC3 controller on QRB4210 board and it is connected > + * via a DIP Switch: > + * - to either an USB - C type connector or an USB - A type connector > + * (via a GL3590-S hub), and > + * - to either an USB - A type connector (via a GL3590-S hub) or a connector > + * for further connection with a mezzanine board. > + * > + * All of the above hardware muxes would allow us to hook things up in > + * different ways to some potential benefit for static configurations (for e.g. > + * on one hand we can have two USB - A type connectors and a USB - Ethernet > + * connection available and on the other we can use the USB - C type in > + * peripheral mode). > + * > + * Note that since the USB - C type can be used only in peripehral mode, > + * so hardcoding the mode to 'peripheral' here makes sense. > + * > + * However since we want to use the EUD debug device, we set the mode as > + * 'otg' here. > + */ > + dr_mode = "otg"; > }; > > &usb_hsphy {