From: Ben Dooks <ben.dooks@codethink.co.uk>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: linux-kernel@lists.codethink.co.uk, dmaengine@vger.kernel.org,
vinod.koul@intel.com, dan.j.williams@intel.com,
linux-sh@vger.kernel.org, magnus.damm@opensource.se,
horms@verge.net.au, g.liakhovetski@gmx.d,
devicetree@vger.kernel.org
Subject: Re: [PATCH v2 9/9] DMA: shdma: wire r8a7790
Date: Wed, 23 Apr 2014 14:08:54 +0100 [thread overview]
Message-ID: <5357BB66.7010707@codethink.co.uk> (raw)
In-Reply-To: <87zjjjbewr.wl%kuninori.morimoto.gx@renesas.com>
On 18/04/14 02:32, Kuninori Morimoto wrote:
>
> Hi Ben
>
> Thank you for your patch
>
>> Add support for R8A7790 with new device tree code.
>>
>> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
>> ---
> (snip)
>> static const struct of_device_id sh_dmae_of_match[] = {
>> - {.compatible = "renesas,shdma-r8a73a4", .data = r8a73a4_shdma_devid,},
>> + { .compatible = "renesas,shdma-r8a73a4", .data = r8a73a4_shdma_devid },
>> + { .compatible = "renesas,dma-r8a7790", .data = &shdma_arm_info },
>> {}
>> };
>
> Here, new compatible name is "renesas,dma-r8a7790"
> ~~~
>
>> + sysdma0: dma-controller@e6700000 {
>> + compatible = "renesas,shdma-r8a7790";
> ..
>> + sysdma1: dma-controller@e6720000 {
>> + compatible = "renesas,shdma-r8a7790";
>
> your [PATCH v2 3/9] ARM: shmobile: r8a7790: add dmac0 dmac1 nodes
> is using "renesas,shdma-r8a7790"
> ~~~~~
>
> Is it miss/typo ?
I think it is a missed rebase, I will be away until next week
so will check this out when I get back.
--
Ben Dooks http://www.codethink.co.uk/
Senior Engineer Codethink - Providing Genius
prev parent reply other threads:[~2014-04-23 13:08 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-14 21:35 Updates Renesas OF-DMA code Ben Dooks
2014-04-14 21:35 ` [PATCH v2 1/9] ARM: shmobile: r8a7790: add dmac0,dmac1 clocks Ben Dooks
2014-05-13 9:23 ` Geert Uytterhoeven
2014-06-04 15:54 ` Ben Dooks
2014-04-14 21:35 ` [PATCH v2 2/9] ARM: shmobile: r8a7790: add dma defines for sys and audio dmacs Ben Dooks
2014-04-14 22:10 ` Arnd Bergmann
2014-04-14 22:51 ` Simon Horman
2014-04-15 9:46 ` Ben Dooks
2014-05-13 8:51 ` Geert Uytterhoeven
2014-05-13 10:46 ` Geert Uytterhoeven
[not found] ` <CAMuHMdUsRSGuGgnAgjKtOWmx3C_PWUxAU=2XTvPE1M9o13S1uA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-05-27 8:08 ` Geert Uytterhoeven
2014-04-14 21:35 ` [PATCH v2 3/9] ARM: shmobile: r8a7790: add dmac0 dmac1 nodes Ben Dooks
[not found] ` <1397511312-4845-4-git-send-email-ben.dooks-4yDnlxn2s6sWdaTGBSpHTA@public.gmane.org>
2014-05-13 12:00 ` Geert Uytterhoeven
[not found] ` <CAMuHMdUNAFJEFWYe5cpKaZqoZFhRA1s0YBntT5ZVJaieSj8ovQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-06-04 16:04 ` Ben Dooks
2014-05-15 13:11 ` Geert Uytterhoeven
2014-04-14 21:35 ` [PATCH v2 4/9] ARM: shmobile: r8a7790: Add DMA for MMCIF1 Ben Dooks
2014-04-14 21:35 ` [PATCH v2 5/9] ARM: shmobile: add Audio DMAC clocks Ben Dooks
2014-04-14 21:35 ` [PATCH v2 6/9] ARM: shmobile: r8a7790: add audio dmac node Ben Dooks
2014-05-13 8:53 ` Geert Uytterhoeven
2014-05-13 12:10 ` Geert Uytterhoeven
2014-05-15 13:12 ` Geert Uytterhoeven
[not found] ` <1397511312-4845-1-git-send-email-ben.dooks-4yDnlxn2s6sWdaTGBSpHTA@public.gmane.org>
2014-04-14 21:35 ` [PATCH v2 7/9] ARM: shmobile: lager: enable sysdma units 0 and 1 Ben Dooks
2014-04-14 21:35 ` [PATCH v2 8/9] DMA: shdma: initial of common code Ben Dooks
2014-04-14 22:06 ` Arnd Bergmann
2014-04-15 9:54 ` Ben Dooks
2014-05-21 20:14 ` Geert Uytterhoeven
2014-06-04 15:54 ` Ben Dooks
2014-04-14 21:35 ` [PATCH v2 9/9] DMA: shdma: wire r8a7790 Ben Dooks
2014-04-15 12:20 ` Sergei Shtylyov
2014-04-18 1:32 ` Kuninori Morimoto
2014-04-23 13:08 ` Ben Dooks [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5357BB66.7010707@codethink.co.uk \
--to=ben.dooks@codethink.co.uk \
--cc=dan.j.williams@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=g.liakhovetski@gmx.d \
--cc=horms@verge.net.au \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=linux-kernel@lists.codethink.co.uk \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@opensource.se \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).