From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Dooks Subject: Re: [PATCH v2 9/9] DMA: shdma: wire r8a7790 Date: Wed, 23 Apr 2014 14:08:54 +0100 Message-ID: <5357BB66.7010707@codethink.co.uk> References: <1397511312-4845-1-git-send-email-ben.dooks@codethink.co.uk> <1397511312-4845-10-git-send-email-ben.dooks@codethink.co.uk> <87zjjjbewr.wl%kuninori.morimoto.gx@renesas.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <87zjjjbewr.wl%kuninori.morimoto.gx@renesas.com> Sender: linux-sh-owner@vger.kernel.org To: Kuninori Morimoto Cc: linux-kernel@lists.codethink.co.uk, dmaengine@vger.kernel.org, vinod.koul@intel.com, dan.j.williams@intel.com, linux-sh@vger.kernel.org, magnus.damm@opensource.se, horms@verge.net.au, g.liakhovetski@gmx.d, devicetree@vger.kernel.org List-Id: devicetree@vger.kernel.org On 18/04/14 02:32, Kuninori Morimoto wrote: > > Hi Ben > > Thank you for your patch > >> Add support for R8A7790 with new device tree code. >> >> Signed-off-by: Ben Dooks >> --- > (snip) >> static const struct of_device_id sh_dmae_of_match[] = { >> - {.compatible = "renesas,shdma-r8a73a4", .data = r8a73a4_shdma_devid,}, >> + { .compatible = "renesas,shdma-r8a73a4", .data = r8a73a4_shdma_devid }, >> + { .compatible = "renesas,dma-r8a7790", .data = &shdma_arm_info }, >> {} >> }; > > Here, new compatible name is "renesas,dma-r8a7790" > ~~~ > >> + sysdma0: dma-controller@e6700000 { >> + compatible = "renesas,shdma-r8a7790"; > .. >> + sysdma1: dma-controller@e6720000 { >> + compatible = "renesas,shdma-r8a7790"; > > your [PATCH v2 3/9] ARM: shmobile: r8a7790: add dmac0 dmac1 nodes > is using "renesas,shdma-r8a7790" > ~~~~~ > > Is it miss/typo ? I think it is a missed rebase, I will be away until next week so will check this out when I get back. -- Ben Dooks http://www.codethink.co.uk/ Senior Engineer Codethink - Providing Genius