From: Benoit Cousson <bcousson@baylibre.com>
To: Tony Lindgren <tony@atomide.com>
Cc: Leigh Brown <leigh@solinno.co.uk>,
Mugunthan V N <mugunthanvnm@ti.com>,
devicetree@vger.kernel.org,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Felipe Balbi <balbi@ti.com>,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH RFC] ARM: dts: am335x: update USB DT references
Date: Wed, 23 Apr 2014 17:35:29 +0200 [thread overview]
Message-ID: <5357DDC1.1070609@baylibre.com> (raw)
In-Reply-To: <20140423144822.GA4833@atomide.com>
Hi Tony,
On 23/04/2014 16:48, Tony Lindgren wrote:
> * Benoit Cousson <bcousson@baylibre.com> [140422 07:14]:
>> Hi Leigh,
>>
>> On 16/04/2014 13:26, Leigh Brown wrote:
>>> In "ARM: dts: am33xx: correcting dt node unit address for usb", the
>>> usb_ctrl_mod and cppi41dma nodes were updated with the correct register
>>> addresses. However, the dts files that reference these nodes were not
>>> updated, and those devices are no longer being enabled.
>>>
>>> This patch corrects the references for the affected dts files.
>>
>> Thanks for the fix. BTW, why is it a RFC? Do you plan to send an updated
>> version?
>>
>> FYI, even with this fix, the BBB still does not have a working MUSB on
>> 3.15-rc2. Have you observed that as well?
>>
>>> Signed-off-by: Leigh Brown <leigh@solinno.co.uk>
>>
>> If this is a final version, I'll apply it for -rc3.
>
> Looks like I already have this in omap-for-v3.15/fixes-v2, sorry
> looks like I never replied to this one.
:-)
OK, I'll let you handle this one.
Thanks,
Benoit
>
> Regards,
>
> Tony
>
>>> ---
>>> arch/arm/boot/dts/am335x-bone-common.dtsi | 4 ++--
>>> arch/arm/boot/dts/am335x-evm.dts | 4 ++--
>>> arch/arm/boot/dts/am335x-evmsk.dts | 4 ++--
>>> arch/arm/boot/dts/am335x-igep0033.dtsi | 4 ++--
>>> 4 files changed, 8 insertions(+), 8 deletions(-)
>>>
>>> diff --git a/arch/arm/boot/dts/am335x-bone-common.dtsi b/arch/arm/boot/dts/am335x-bone-common.dtsi
>>> index e3f27ec..2e7d932 100644
>>> --- a/arch/arm/boot/dts/am335x-bone-common.dtsi
>>> +++ b/arch/arm/boot/dts/am335x-bone-common.dtsi
>>> @@ -183,7 +183,7 @@
>>> &usb {
>>> status = "okay";
>>>
>>> - control@44e10000 {
>>> + control@44e10620 {
>>> status = "okay";
>>> };
>>>
>>> @@ -204,7 +204,7 @@
>>> dr_mode = "host";
>>> };
>>>
>>> - dma-controller@07402000 {
>>> + dma-controller@47402000 {
>>> status = "okay";
>>> };
>>> };
>>> diff --git a/arch/arm/boot/dts/am335x-evm.dts b/arch/arm/boot/dts/am335x-evm.dts
>>> index 28ae040..77df10d 100644
>>> --- a/arch/arm/boot/dts/am335x-evm.dts
>>> +++ b/arch/arm/boot/dts/am335x-evm.dts
>>> @@ -331,7 +331,7 @@
>>> &usb {
>>> status = "okay";
>>>
>>> - control@44e10000 {
>>> + control@44e10620 {
>>> status = "okay";
>>> };
>>>
>>> @@ -352,7 +352,7 @@
>>> dr_mode = "host";
>>> };
>>>
>>> - dma-controller@07402000 {
>>> + dma-controller@47402000 {
>>> status = "okay";
>>> };
>>> };
>>> diff --git a/arch/arm/boot/dts/am335x-evmsk.dts b/arch/arm/boot/dts/am335x-evmsk.dts
>>> index ec08f6f..ab23885 100644
>>> --- a/arch/arm/boot/dts/am335x-evmsk.dts
>>> +++ b/arch/arm/boot/dts/am335x-evmsk.dts
>>> @@ -364,7 +364,7 @@
>>> &usb {
>>> status = "okay";
>>>
>>> - control@44e10000 {
>>> + control@44e10620 {
>>> status = "okay";
>>> };
>>>
>>> @@ -385,7 +385,7 @@
>>> dr_mode = "host";
>>> };
>>>
>>> - dma-controller@07402000 {
>>> + dma-controller@47402000 {
>>> status = "okay";
>>> };
>>> };
>>> diff --git a/arch/arm/boot/dts/am335x-igep0033.dtsi b/arch/arm/boot/dts/am335x-igep0033.dtsi
>>> index 7063311..5942e7d 100644
>>> --- a/arch/arm/boot/dts/am335x-igep0033.dtsi
>>> +++ b/arch/arm/boot/dts/am335x-igep0033.dtsi
>>> @@ -202,7 +202,7 @@
>>> &usb {
>>> status = "okay";
>>>
>>> - control@44e10000 {
>>> + control@44e10620 {
>>> status = "okay";
>>> };
>>>
>>> @@ -223,7 +223,7 @@
>>> dr_mode = "host";
>>> };
>>>
>>> - dma-controller@07402000 {
>>> + dma-controller@47402000 {
>>> status = "okay";
>>> };
>>> };
>>>
>>
>>
>> --
>> Benoît Cousson
>> BayLibre
>> Embedded Linux Technology Lab
>> www.baylibre.com
--
Benoît Cousson
BayLibre
Embedded Linux Technology Lab
www.baylibre.com
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2014-04-23 15:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-16 11:26 [PATCH RFC] ARM: dts: am335x: update USB DT references Leigh Brown
2014-04-22 14:14 ` Benoit Cousson
2014-04-23 14:48 ` Tony Lindgren
2014-04-23 15:17 ` Ezequiel Garcia
2014-04-23 15:40 ` Benoit Cousson
2014-04-23 15:48 ` Ezequiel Garcia
2014-04-23 15:35 ` Benoit Cousson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5357DDC1.1070609@baylibre.com \
--to=bcousson@baylibre.com \
--cc=balbi@ti.com \
--cc=bigeasy@linutronix.de \
--cc=devicetree@vger.kernel.org \
--cc=leigh@solinno.co.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=mugunthanvnm@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).