devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
To: "Antoine Ténart" <antoine.tenart@free-electrons.com>
Cc: alexandre.belloni@free-electrons.com, zmxu@marvell.com,
	jszhang@marvell.com, linux-arm-kernel@lists.infradead.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] ARM: dts: berlin: enable SD card reader and eMMC for the BG2Q DMP
Date: Wed, 23 Apr 2014 19:26:23 +0200	[thread overview]
Message-ID: <5357F7BF.8000703@gmail.com> (raw)
In-Reply-To: <1398155248-1659-3-git-send-email-antoine.tenart@free-electrons.com>

On 04/22/2014 10:27 AM, Antoine Ténart wrote:
> Enable the SD Card reader and the internal eMMC on the Berlin BG2Q DMP
> using two of the SDHCI nodes of the Berlin BG2Q.
> 
> Signed-off-by: Antoine Ténart <antoine.tenart@free-electrons.com>
> ---
>  arch/arm/boot/dts/berlin2q-marvell-dmp.dts | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/berlin2q-marvell-dmp.dts b/arch/arm/boot/dts/berlin2q-marvell-dmp.dts
> index 2da9c41e29d8..6ca8c9e52b08 100644
> --- a/arch/arm/boot/dts/berlin2q-marvell-dmp.dts
> +++ b/arch/arm/boot/dts/berlin2q-marvell-dmp.dts
> @@ -26,3 +26,14 @@
>  &uart0 {
>  	status = "okay";
>  };
> +
> +&sdhci1 {

Antoine,

nit: please sort referenced nodes alphabetically.

With your comments about mmc aliases, I can take both patches
in now (and fixup ordering) if you like.

Sebastian

> +	broken-cd;
> +	sdhci,wp-inverted;
> +	status = "okay";
> +};
> +
> +&sdhci2 {
> +	non-removable;
> +	status = "okay";
> +};
> 

  reply	other threads:[~2014-04-23 17:26 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-22  8:27 [PATCH v2 0/2] ARM: berlin: add SDHCI support Antoine Ténart
2014-04-22  8:27 ` [PATCH v2 1/2] ARM: dts: berlin: add the SDHCI nodes for the BG2Q Antoine Ténart
     [not found]   ` <1398155248-1659-2-git-send-email-antoine.tenart-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2014-04-22 17:35     ` Sebastian Hesselbarth
     [not found]       ` <5356A85F.6030708-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-04-23  9:02         ` Antoine Ténart
2014-04-22  8:27 ` [PATCH v2 2/2] ARM: dts: berlin: enable SD card reader and eMMC for the BG2Q DMP Antoine Ténart
2014-04-23 17:26   ` Sebastian Hesselbarth [this message]
2014-04-23 17:36     ` Antoine Ténart
2014-04-23 17:43       ` Sebastian Hesselbarth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5357F7BF.8000703@gmail.com \
    --to=sebastian.hesselbarth@gmail.com \
    --cc=alexandre.belloni@free-electrons.com \
    --cc=antoine.tenart@free-electrons.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jszhang@marvell.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=zmxu@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).