From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Geert Uytterhoeven <geert+renesas@glider.be>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Ben Dooks <ben.dooks@codethink.co.uk>,
linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org,
linux-sh@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 1/6] PM / clock_ops: Add helpers combining generic runtime and generic clock PM
Date: Thu, 24 Apr 2014 15:16:49 +0400 [thread overview]
Message-ID: <5358F2A1.40106@cogentembedded.com> (raw)
In-Reply-To: <1398335198-26555-2-git-send-email-geert+renesas@glider.be>
Hello.
On 24-04-2014 14:26, Geert Uytterhoeven wrote:
> Add helpers pm_generic_runtime_clk_suspend() and
> pm_generic_clk_runtime_resume(), combining generic runtime PM and generic
> clock PM.
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
[...]
> diff --git a/include/linux/pm_clock.h b/include/linux/pm_clock.h
> index 6981aa288c45..bf1e4d09a0ca 100644
> --- a/include/linux/pm_clock.h
> +++ b/include/linux/pm_clock.h
> @@ -35,6 +35,8 @@ extern int pm_clk_add_clk(struct device *dev, struct clk *clk);
> extern void pm_clk_remove(struct device *dev, const char *con_id);
> extern int pm_clk_suspend(struct device *dev);
> extern int pm_clk_resume(struct device *dev);
> +extern int pm_generic_runtime_clk_suspend(struct device *dev);
> +extern int pm_generic_clk_runtime_resume(struct device *dev);
Shouldn't these function names be symmetric? I think '_clk' and '_runtime'
need swapping in one case.
WBR, Sergei
next prev parent reply other threads:[~2014-04-24 11:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-24 10:26 [PATCH 0/6] PM / clock_ops: Add helpers combining generic runtime and generic clock PM Geert Uytterhoeven
2014-04-24 10:26 ` [PATCH 1/6] " Geert Uytterhoeven
2014-04-24 11:16 ` Sergei Shtylyov [this message]
2014-04-24 10:26 ` [PATCH 2/6] ARM: davinci: Use generic runtime and clock helpers Geert Uytterhoeven
2014-04-24 10:26 ` [PATCH 3/6] ARM: keystone: " Geert Uytterhoeven
2014-04-24 10:26 ` [PATCH 4/6] ARM: omap: " Geert Uytterhoeven
2014-04-24 10:26 ` [PATCH 5/6] drivers: sh: " Geert Uytterhoeven
2014-04-24 10:26 ` [PATCH 6/6] of/clk: " Geert Uytterhoeven
2014-04-24 13:26 ` [PATCH 0/6] PM / clock_ops: Add helpers combining generic runtime and generic clock PM Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5358F2A1.40106@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=ben.dooks@codethink.co.uk \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).