From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sebastian Hesselbarth Subject: Re: [PATCH RFC 0/5] Dove PMU support Date: Mon, 28 Apr 2014 09:47:39 +0200 Message-ID: <535E079B.6010701@gmail.com> References: <20140427132312.GC26756@n2100.arm.linux.org.uk> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20140427132312.GC26756@n2100.arm.linux.org.uk> Sender: linux-pm-owner@vger.kernel.org To: Russell King - ARM Linux , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org, Mark Rutland , Pawel Moll , "Rafael J. Wysocki" , Rob Herring List-Id: devicetree@vger.kernel.org On 04/27/2014 03:23 PM, Russell King - ARM Linux wrote: > The following series of patches add better PMU support for Dove. This > has been developed on the Cubox, and tested in non-DT and DT modes. > > This also improves the interrupt handling over the existing code: the > existing code ends up calling the interrupt handlers twice for every > interrupt raised, because the interrupt clear-down is done at the > wrong point - we need to clear down the interrupt in the device first, > then clear it down in the controller. > > The problem this gives is that it can be racy (see comments in the > driver) so we're careful about how we do that to minimise the window. > > I've included all patches here - the initial set are targetted towards > adding DT support, with the final adding the non-DT support. There is > a call to the initialisation function missing for DT mode - I'd like > the mvebu people to comment on how that should be handled, as it needs > to be done pretty early. > > Also included are two PM domain changes: the first I've discussed with > Rafael who seems happy with it. The second is necessary because we > have no way to know if a generic PM domain is associated with a device > or whether something else making use of the PM domain is installed in > the dev->pm_domain pointer, so this allows that decision to be made by > core PM code. > > This is more a "this is where I'm at" with this stuff than a real > submission, nevertheless comments on how to get it ready for submission > would be welcome. I'd like to get this off my plate ASAP. Russell, thanks for dropping those patches. I know you are packed with a bunch of other patch sets, so if you agree, I can pick up your Dove related patches and finish them. One thing that comes into my mind is, that we moved Dove DT to mach-mvebu starting with v3.15-rc1 so we need to find a better place for the driver than mach-dove. Sebastian > arch/arm/Kconfig | 1 + > arch/arm/boot/dts/dove.dtsi | 7 + > arch/arm/mach-dove/Makefile | 1 + > arch/arm/mach-dove/common.c | 2 + > arch/arm/mach-dove/common.h | 1 + > arch/arm/mach-dove/include/mach/pm.h | 17 -- > arch/arm/mach-dove/irq.c | 87 ------ > arch/arm/mach-dove/pmu.c | 531 +++++++++++++++++++++++++++++++++++ > drivers/base/power/domain.c | 8 +- > 9 files changed, 547 insertions(+), 108 deletions(-) >