* [PATCHv2] arm: dts: am33xx-clock: Fix ehrpwm tbclk data.
@ 2014-04-29 8:34 Sourav Poddar
2014-04-29 12:48 ` Tero Kristo
2014-05-20 15:22 ` Mike Turquette
0 siblings, 2 replies; 4+ messages in thread
From: Sourav Poddar @ 2014-04-29 8:34 UTC (permalink / raw)
To: t-kristo, mturquette, tony, devicetree, linux-omap, balbi; +Cc: Sourav Poddar
tbclk does not need to be a composite clock, we can simply
use gate clock for this purpose.
Signed-off-by: Sourav Poddar <sourav.poddar@ti.com>
---
v1->v2:
change compatible string according to mainline.
arch/arm/boot/dts/am33xx-clocks.dtsi | 30 ++++++------------------------
1 file changed, 6 insertions(+), 24 deletions(-)
diff --git a/arch/arm/boot/dts/am33xx-clocks.dtsi b/arch/arm/boot/dts/am33xx-clocks.dtsi
index 9ccfe50..712edce 100644
--- a/arch/arm/boot/dts/am33xx-clocks.dtsi
+++ b/arch/arm/boot/dts/am33xx-clocks.dtsi
@@ -96,47 +96,29 @@
clock-div = <1>;
};
- ehrpwm0_gate_tbclk: ehrpwm0_gate_tbclk {
+ ehrpwm0_tbclk: ehrpwm0_tbclk@44e10664 {
#clock-cells = <0>;
- compatible = "ti,composite-no-wait-gate-clock";
+ compatible = "ti,gate-clock";
clocks = <&dpll_per_m2_ck>;
ti,bit-shift = <0>;
reg = <0x0664>;
};
- ehrpwm0_tbclk: ehrpwm0_tbclk {
- #clock-cells = <0>;
- compatible = "ti,composite-clock";
- clocks = <&ehrpwm0_gate_tbclk>;
- };
-
- ehrpwm1_gate_tbclk: ehrpwm1_gate_tbclk {
+ ehrpwm1_tbclk: ehrpwm1_tbclk@44e10664 {
#clock-cells = <0>;
- compatible = "ti,composite-no-wait-gate-clock";
+ compatible = "ti,gate-clock";
clocks = <&dpll_per_m2_ck>;
ti,bit-shift = <1>;
reg = <0x0664>;
};
- ehrpwm1_tbclk: ehrpwm1_tbclk {
- #clock-cells = <0>;
- compatible = "ti,composite-clock";
- clocks = <&ehrpwm1_gate_tbclk>;
- };
-
- ehrpwm2_gate_tbclk: ehrpwm2_gate_tbclk {
+ ehrpwm2_tbclk: ehrpwm2_tbclk@44e10664 {
#clock-cells = <0>;
- compatible = "ti,composite-no-wait-gate-clock";
+ compatible = "ti,gate-clock";
clocks = <&dpll_per_m2_ck>;
ti,bit-shift = <2>;
reg = <0x0664>;
};
-
- ehrpwm2_tbclk: ehrpwm2_tbclk {
- #clock-cells = <0>;
- compatible = "ti,composite-clock";
- clocks = <&ehrpwm2_gate_tbclk>;
- };
};
&prcm_clocks {
clk_32768_ck: clk_32768_ck {
--
1.7.9.5
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCHv2] arm: dts: am33xx-clock: Fix ehrpwm tbclk data.
2014-04-29 8:34 [PATCHv2] arm: dts: am33xx-clock: Fix ehrpwm tbclk data Sourav Poddar
@ 2014-04-29 12:48 ` Tero Kristo
2014-05-19 13:17 ` Tero Kristo
2014-05-20 15:22 ` Mike Turquette
1 sibling, 1 reply; 4+ messages in thread
From: Tero Kristo @ 2014-04-29 12:48 UTC (permalink / raw)
To: Sourav Poddar, mturquette, tony, devicetree, linux-omap, balbi
On 04/29/2014 11:34 AM, Sourav Poddar wrote:
> tbclk does not need to be a composite clock, we can simply
> use gate clock for this purpose.
>
> Signed-off-by: Sourav Poddar <sourav.poddar@ti.com>
Looks good to me so:
Acked-by: Tero Kristo <t-kristo@ti.com>
> ---
> v1->v2:
> change compatible string according to mainline.
> arch/arm/boot/dts/am33xx-clocks.dtsi | 30 ++++++------------------------
> 1 file changed, 6 insertions(+), 24 deletions(-)
>
> diff --git a/arch/arm/boot/dts/am33xx-clocks.dtsi b/arch/arm/boot/dts/am33xx-clocks.dtsi
> index 9ccfe50..712edce 100644
> --- a/arch/arm/boot/dts/am33xx-clocks.dtsi
> +++ b/arch/arm/boot/dts/am33xx-clocks.dtsi
> @@ -96,47 +96,29 @@
> clock-div = <1>;
> };
>
> - ehrpwm0_gate_tbclk: ehrpwm0_gate_tbclk {
> + ehrpwm0_tbclk: ehrpwm0_tbclk@44e10664 {
> #clock-cells = <0>;
> - compatible = "ti,composite-no-wait-gate-clock";
> + compatible = "ti,gate-clock";
> clocks = <&dpll_per_m2_ck>;
> ti,bit-shift = <0>;
> reg = <0x0664>;
> };
>
> - ehrpwm0_tbclk: ehrpwm0_tbclk {
> - #clock-cells = <0>;
> - compatible = "ti,composite-clock";
> - clocks = <&ehrpwm0_gate_tbclk>;
> - };
> -
> - ehrpwm1_gate_tbclk: ehrpwm1_gate_tbclk {
> + ehrpwm1_tbclk: ehrpwm1_tbclk@44e10664 {
> #clock-cells = <0>;
> - compatible = "ti,composite-no-wait-gate-clock";
> + compatible = "ti,gate-clock";
> clocks = <&dpll_per_m2_ck>;
> ti,bit-shift = <1>;
> reg = <0x0664>;
> };
>
> - ehrpwm1_tbclk: ehrpwm1_tbclk {
> - #clock-cells = <0>;
> - compatible = "ti,composite-clock";
> - clocks = <&ehrpwm1_gate_tbclk>;
> - };
> -
> - ehrpwm2_gate_tbclk: ehrpwm2_gate_tbclk {
> + ehrpwm2_tbclk: ehrpwm2_tbclk@44e10664 {
> #clock-cells = <0>;
> - compatible = "ti,composite-no-wait-gate-clock";
> + compatible = "ti,gate-clock";
> clocks = <&dpll_per_m2_ck>;
> ti,bit-shift = <2>;
> reg = <0x0664>;
> };
> -
> - ehrpwm2_tbclk: ehrpwm2_tbclk {
> - #clock-cells = <0>;
> - compatible = "ti,composite-clock";
> - clocks = <&ehrpwm2_gate_tbclk>;
> - };
> };
> &prcm_clocks {
> clk_32768_ck: clk_32768_ck {
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCHv2] arm: dts: am33xx-clock: Fix ehrpwm tbclk data.
2014-04-29 12:48 ` Tero Kristo
@ 2014-05-19 13:17 ` Tero Kristo
0 siblings, 0 replies; 4+ messages in thread
From: Tero Kristo @ 2014-05-19 13:17 UTC (permalink / raw)
To: Sourav Poddar, mturquette, tony, devicetree, linux-omap, balbi
On 04/29/2014 03:48 PM, Tero Kristo wrote:
> On 04/29/2014 11:34 AM, Sourav Poddar wrote:
>> tbclk does not need to be a composite clock, we can simply
>> use gate clock for this purpose.
>>
>> Signed-off-by: Sourav Poddar <sourav.poddar@ti.com>
>
> Looks good to me so:
>
> Acked-by: Tero Kristo <t-kristo@ti.com>
Also, queued for 3.15-rc/clk-dt.
-Tero
>
>> ---
>> v1->v2:
>> change compatible string according to mainline.
>> arch/arm/boot/dts/am33xx-clocks.dtsi | 30
>> ++++++------------------------
>> 1 file changed, 6 insertions(+), 24 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/am33xx-clocks.dtsi
>> b/arch/arm/boot/dts/am33xx-clocks.dtsi
>> index 9ccfe50..712edce 100644
>> --- a/arch/arm/boot/dts/am33xx-clocks.dtsi
>> +++ b/arch/arm/boot/dts/am33xx-clocks.dtsi
>> @@ -96,47 +96,29 @@
>> clock-div = <1>;
>> };
>>
>> - ehrpwm0_gate_tbclk: ehrpwm0_gate_tbclk {
>> + ehrpwm0_tbclk: ehrpwm0_tbclk@44e10664 {
>> #clock-cells = <0>;
>> - compatible = "ti,composite-no-wait-gate-clock";
>> + compatible = "ti,gate-clock";
>> clocks = <&dpll_per_m2_ck>;
>> ti,bit-shift = <0>;
>> reg = <0x0664>;
>> };
>>
>> - ehrpwm0_tbclk: ehrpwm0_tbclk {
>> - #clock-cells = <0>;
>> - compatible = "ti,composite-clock";
>> - clocks = <&ehrpwm0_gate_tbclk>;
>> - };
>> -
>> - ehrpwm1_gate_tbclk: ehrpwm1_gate_tbclk {
>> + ehrpwm1_tbclk: ehrpwm1_tbclk@44e10664 {
>> #clock-cells = <0>;
>> - compatible = "ti,composite-no-wait-gate-clock";
>> + compatible = "ti,gate-clock";
>> clocks = <&dpll_per_m2_ck>;
>> ti,bit-shift = <1>;
>> reg = <0x0664>;
>> };
>>
>> - ehrpwm1_tbclk: ehrpwm1_tbclk {
>> - #clock-cells = <0>;
>> - compatible = "ti,composite-clock";
>> - clocks = <&ehrpwm1_gate_tbclk>;
>> - };
>> -
>> - ehrpwm2_gate_tbclk: ehrpwm2_gate_tbclk {
>> + ehrpwm2_tbclk: ehrpwm2_tbclk@44e10664 {
>> #clock-cells = <0>;
>> - compatible = "ti,composite-no-wait-gate-clock";
>> + compatible = "ti,gate-clock";
>> clocks = <&dpll_per_m2_ck>;
>> ti,bit-shift = <2>;
>> reg = <0x0664>;
>> };
>> -
>> - ehrpwm2_tbclk: ehrpwm2_tbclk {
>> - #clock-cells = <0>;
>> - compatible = "ti,composite-clock";
>> - clocks = <&ehrpwm2_gate_tbclk>;
>> - };
>> };
>> &prcm_clocks {
>> clk_32768_ck: clk_32768_ck {
>>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCHv2] arm: dts: am33xx-clock: Fix ehrpwm tbclk data.
2014-04-29 8:34 [PATCHv2] arm: dts: am33xx-clock: Fix ehrpwm tbclk data Sourav Poddar
2014-04-29 12:48 ` Tero Kristo
@ 2014-05-20 15:22 ` Mike Turquette
1 sibling, 0 replies; 4+ messages in thread
From: Mike Turquette @ 2014-05-20 15:22 UTC (permalink / raw)
To: t-kristo, tony, devicetree, linux-omap, balbi; +Cc: Sourav Poddar
Quoting Sourav Poddar (2014-04-29 01:34:20)
> tbclk does not need to be a composite clock, we can simply
> use gate clock for this purpose.
>
> Signed-off-by: Sourav Poddar <sourav.poddar@ti.com>
Looks good.
Regards,
Mike
> ---
> v1->v2:
> change compatible string according to mainline.
> arch/arm/boot/dts/am33xx-clocks.dtsi | 30 ++++++------------------------
> 1 file changed, 6 insertions(+), 24 deletions(-)
>
> diff --git a/arch/arm/boot/dts/am33xx-clocks.dtsi b/arch/arm/boot/dts/am33xx-clocks.dtsi
> index 9ccfe50..712edce 100644
> --- a/arch/arm/boot/dts/am33xx-clocks.dtsi
> +++ b/arch/arm/boot/dts/am33xx-clocks.dtsi
> @@ -96,47 +96,29 @@
> clock-div = <1>;
> };
>
> - ehrpwm0_gate_tbclk: ehrpwm0_gate_tbclk {
> + ehrpwm0_tbclk: ehrpwm0_tbclk@44e10664 {
> #clock-cells = <0>;
> - compatible = "ti,composite-no-wait-gate-clock";
> + compatible = "ti,gate-clock";
> clocks = <&dpll_per_m2_ck>;
> ti,bit-shift = <0>;
> reg = <0x0664>;
> };
>
> - ehrpwm0_tbclk: ehrpwm0_tbclk {
> - #clock-cells = <0>;
> - compatible = "ti,composite-clock";
> - clocks = <&ehrpwm0_gate_tbclk>;
> - };
> -
> - ehrpwm1_gate_tbclk: ehrpwm1_gate_tbclk {
> + ehrpwm1_tbclk: ehrpwm1_tbclk@44e10664 {
> #clock-cells = <0>;
> - compatible = "ti,composite-no-wait-gate-clock";
> + compatible = "ti,gate-clock";
> clocks = <&dpll_per_m2_ck>;
> ti,bit-shift = <1>;
> reg = <0x0664>;
> };
>
> - ehrpwm1_tbclk: ehrpwm1_tbclk {
> - #clock-cells = <0>;
> - compatible = "ti,composite-clock";
> - clocks = <&ehrpwm1_gate_tbclk>;
> - };
> -
> - ehrpwm2_gate_tbclk: ehrpwm2_gate_tbclk {
> + ehrpwm2_tbclk: ehrpwm2_tbclk@44e10664 {
> #clock-cells = <0>;
> - compatible = "ti,composite-no-wait-gate-clock";
> + compatible = "ti,gate-clock";
> clocks = <&dpll_per_m2_ck>;
> ti,bit-shift = <2>;
> reg = <0x0664>;
> };
> -
> - ehrpwm2_tbclk: ehrpwm2_tbclk {
> - #clock-cells = <0>;
> - compatible = "ti,composite-clock";
> - clocks = <&ehrpwm2_gate_tbclk>;
> - };
> };
> &prcm_clocks {
> clk_32768_ck: clk_32768_ck {
> --
> 1.7.9.5
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-05-20 15:22 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-04-29 8:34 [PATCHv2] arm: dts: am33xx-clock: Fix ehrpwm tbclk data Sourav Poddar
2014-04-29 12:48 ` Tero Kristo
2014-05-19 13:17 ` Tero Kristo
2014-05-20 15:22 ` Mike Turquette
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).