From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C1937374F5 for ; Mon, 9 Oct 2023 17:49:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="fy6p6D7a" Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5BAE0AF; Mon, 9 Oct 2023 10:49:57 -0700 (PDT) Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 399Hitmx010618; Mon, 9 Oct 2023 17:49:47 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=IPuLfY1co6cd9F2y/mCmzIMjZ4Z5GLyj7fCatcrQ81c=; b=fy6p6D7aWklBtBaHFs50UakU4q3uh7K5dW9U75uWpS7PboE6ia5j+WcpvVgvMYt+4p1X 7nt1Dr0lC8Xw0DMWza4G0R8F4hiE0jTA6cPKXGbMohd79wCdUW22eYMKsVBJIUhI1kPg j8jkxcAb5j8gK5SoLrVSf9i8BWwvtr8IoL1FnG17WOplGbTyUaBphTlT4E4kj4ZWqxca nr5mtXDrssHcEKfV9Dw0O2KNixeVHuHj5VVjKhMIyI9BL843Et3X7lrgXQvuLqvjd6m9 WPJbW1Don7nPOIvijRiEPA8A5s/BV516cawPA0JNWrXB0M86ano/IcR85eCRdGtaqx0N Gg== Received: from nalasppmta05.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3tkh4tb6yj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 09 Oct 2023 17:49:46 +0000 Received: from nalasex01c.na.qualcomm.com (nalasex01c.na.qualcomm.com [10.47.97.35]) by NALASPPMTA05.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 399Hnjso017405 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 9 Oct 2023 17:49:45 GMT Received: from [10.110.87.129] (10.80.80.8) by nalasex01c.na.qualcomm.com (10.47.97.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.30; Mon, 9 Oct 2023 10:49:44 -0700 Message-ID: <535bbc68-74bb-21e8-0e72-8de1df9cfc99@quicinc.com> Date: Mon, 9 Oct 2023 10:49:44 -0700 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v5 2/2] firmware: arm_scmi: Add qcom smc/hvc transport support To: Sudeep Holla CC: , , , , , , , , , References: <20230718160833.36397-1-quic_nkela@quicinc.com> <20231006164206.40710-1-quic_nkela@quicinc.com> <20231006164206.40710-3-quic_nkela@quicinc.com> <20231009144744.yi44ljq4llaxjsb7@bogus> <20231009152952.dww3fgh5q7fqysps@bogus> Content-Language: en-US From: Nikunj Kela In-Reply-To: <20231009152952.dww3fgh5q7fqysps@bogus> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01c.na.qualcomm.com (10.47.97.35) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: c2_Uf1AAKfw4Lwo-4eIWLZmNsYEu5aDS X-Proofpoint-ORIG-GUID: c2_Uf1AAKfw4Lwo-4eIWLZmNsYEu5aDS X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.267,Aquarius:18.0.980,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-10-09_15,2023-10-09_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=999 priorityscore=1501 lowpriorityscore=0 phishscore=0 clxscore=1015 spamscore=0 impostorscore=0 bulkscore=0 malwarescore=0 adultscore=0 suspectscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2309180000 definitions=main-2310090146 X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net On 10/9/2023 8:29 AM, Sudeep Holla wrote: > On Mon, Oct 09, 2023 at 07:59:08AM -0700, Nikunj Kela wrote: >> On 10/9/2023 7:47 AM, Sudeep Holla wrote: >>> On Fri, Oct 06, 2023 at 09:42:06AM -0700, Nikunj Kela wrote: >>>> This change adds the support for SCMI message exchange on Qualcomm >>>> virtual platforms. >>>> >>>> The hypervisor associates an object-id also known as capability-id >>>> with each smc/hvc doorbell object. The capability-id is used to >>>> identify the doorbell from the VM's capability namespace, similar >>>> to a file-descriptor. >>>> >>>> The hypervisor, in addition to the function-id, expects the capability-id >>>> to be passed in x1 register when SMC/HVC call is invoked. >>>> >>>> The capability-id is allocated by the hypervisor on bootup and is stored in >>>> the shmem region by the firmware before starting Linux. >>>> >>> Since you are happy to move to signed value, I assume you are happy to loose >>> upper half of the range values ? >>> >>> Anyways after Bjorn pointed out inconsistency, I am thinking of moving >>> all the values to unsigned long to work with both 32bit and 64bit. >>> >>> Does the below delta on top of this patch works for you and makes sense? >> This looks good to me. Will do some testing and float v6 with the changes >> you suggested below. Thanks >> > Please refer or use the patch from [1] when reposting. I rebased on my > patch[2] that I posted few minutes back. I am trying to finalise the branch > and send PR in next couple of days, so please test and post sooner. Sorry > for the rush. Validated the patch from [1] below on Qualcomm ARM64 virtual platform using SMC64 convention. Thanks! > > -- > Regards, > Sudeep > [1] https://git.kernel.org/sudeep.holla/h/for-next/scmi/updates > [2] https://lore.kernel.org/r/20231009152049.1428872-1-sudeep.holla@arm.com