From: Stanimir Varbanov <svarbanov@mm-sol.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: "David S. Miller" <davem@davemloft.net>,
Grant Likely <grant.likely@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
linux-arm-msm@vger.kernel.org,
Mona Hossain <mhossain@codeaurora.org>,
Hariprasad Dhalinarasimha <hnamgund@codeaurora.org>,
Zhen Kong <zkong@codeaurora.org>,
Niranjana Vishwanathapura <nvishwan@codeaurora.org>,
Rohit Vaswani <rvaswani@codeaurora.org>,
linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [RFC PATCH v2 1/9] crypto: qce: Add core driver implementation
Date: Wed, 30 Apr 2014 19:35:41 +0300 [thread overview]
Message-ID: <5361265D.2000706@mm-sol.com> (raw)
In-Reply-To: <20140428085928.GA16310@gondor.apana.org.au>
Hi Herbert,
On 04/28/2014 11:59 AM, Herbert Xu wrote:
> On Mon, Apr 14, 2014 at 03:48:37PM +0300, Stanimir Varbanov wrote:
>>
>> +#define QCE_MAJOR_VERSION5 0x05
>> +#define QCE_QUEUE_LENGTH 50
>
> What is the purpose of this software queue? Why can't you directly
> feed the requests to the hardware?
Good question. This is a leftover from original driver.
The hardware can handle one request at a time. After you raise the
question I think the queue length should be 1 or remove it completely. I
don't know why the original codeaurora's driver use 50.
>
> If the hardware can't handle more than 50 requests in-flight,
> then your software queue has failed to handle this since you're
> taking requests off the queue before you touch the hardware so
> you're not really limiting it to 50. That is, for users that
> can wait you're potentially dropping their requests instead
> of letting them wait through the backlog mechanism.
--
regards,
Stan
next prev parent reply other threads:[~2014-04-30 16:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-14 12:48 [RFC PATCH v2 0/9] Add Qualcomm crypto driver Stanimir Varbanov
2014-04-14 12:48 ` [RFC PATCH v2 1/9] crypto: qce: Add core driver implementation Stanimir Varbanov
2014-04-28 8:50 ` Herbert Xu
2014-04-29 14:38 ` Stanimir Varbanov
2014-04-30 0:03 ` Herbert Xu
2014-04-28 8:59 ` Herbert Xu
2014-04-30 16:35 ` Stanimir Varbanov [this message]
2014-05-08 21:57 ` Stanimir Vabanov
2014-05-13 11:06 ` Herbert Xu
2014-04-14 12:48 ` [RFC PATCH v2 9/9] ARM: DT: qcom: Add Qualcomm crypto driver binding document Stanimir Varbanov
2014-04-16 15:10 ` [RFC PATCH v2 0/9] Add Qualcomm crypto driver Stanimir Varbanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5361265D.2000706@mm-sol.com \
--to=svarbanov@mm-sol.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=grant.likely@linaro.org \
--cc=herbert@gondor.apana.org.au \
--cc=hnamgund@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhossain@codeaurora.org \
--cc=nvishwan@codeaurora.org \
--cc=robh+dt@kernel.org \
--cc=rvaswani@codeaurora.org \
--cc=zkong@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).