From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomasz Figa Subject: Re: [PATCH v3 00/16] exynos5420: clock file cleanup Date: Thu, 01 May 2014 23:11:34 +0200 Message-ID: <5362B886.9040308@gmail.com> References: <1398344632-18623-1-git-send-email-shaik.ameer@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1398344632-18623-1-git-send-email-shaik.ameer@samsung.com> Sender: linux-samsung-soc-owner@vger.kernel.org To: Shaik Ameer Basha , linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: mturquette@linaro.org, kgene.kim@samsung.com, joshi@samsung.com, shaik.samsung@gmail.com, r.sh.open@gmail.com List-Id: devicetree@vger.kernel.org Hi Shaik, On 24.04.2014 15:03, Shaik Ameer Basha wrote: > Many changes/fixes have been identified for clock file for exynos5420. > These include correct parents, bit fields, new clocks etc. Existing > files needs some correction in terms of names of the clock and > indentation. These issues are addressed in this patch series. It also > replaces the usage of enums with macro as clock ids. > > This patch series is rebased on, > git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git:master > > This patch is also dependent on the following patch. > ARM: dts: add dt node for sss module for exynos5250/5420 I think it would be nice to mention on what hardware this series was tested and how. Also I'd like to see contents of /sys/kernel/debug/clk/clk_summary and /sys/kernel/debug/clk/orphans/ before and after applying this series. Best regards, Tomasz